Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: chrome/browser/extensions/chrome_extension_function.h

Issue 950023005: [Extensions] Apply WARN_UNUSED_RESULT and final keyword to ExtensionFunctions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix chromeos api Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/api/networking_config/networking_config_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/chrome_extension_function.h
diff --git a/chrome/browser/extensions/chrome_extension_function.h b/chrome/browser/extensions/chrome_extension_function.h
index 4051ba18921a543af9073273df4b9b9c2f05070a..dbf00997a24865d96994d9345059603e30a25c7f 100644
--- a/chrome/browser/extensions/chrome_extension_function.h
+++ b/chrome/browser/extensions/chrome_extension_function.h
@@ -87,7 +87,10 @@ class ChromeAsyncExtensionFunction : public ChromeUIThreadExtensionFunction {
static bool ValidationFailure(ChromeAsyncExtensionFunction* function);
private:
- ResponseAction Run() override;
+ // If you're hitting a compile error here due to "final" - great! You're doing
+ // the right thing, you just need to extend ChromeUIThreadExtensionFunction
+ // instead of ChromeAsyncExtensionFunction.
+ ResponseAction Run() final;
};
// A chrome specific analog to SyncExtensionFunction. This has access to a
@@ -111,7 +114,10 @@ class ChromeSyncExtensionFunction : public ChromeUIThreadExtensionFunction {
static bool ValidationFailure(ChromeSyncExtensionFunction* function);
private:
- ResponseAction Run() override;
+ // If you're hitting a compile error here due to "final" - great! You're doing
+ // the right thing, you just need to extend ChromeUIThreadExtensionFunction
+ // instead of ChromeSyncExtensionFunction.
+ ResponseAction Run() final;
};
#endif // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_
« no previous file with comments | « no previous file | extensions/browser/api/networking_config/networking_config_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698