chromeos/network/onc/onc_translation_tables.cc - Issue 949783003: Add WiMAX to ONC validation list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_translation_tables.cc

Issue 949783003: Add WiMAX to ONC validation list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add and fix tests Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_translation_tables.cc

diff --git a/chromeos/network/onc/onc_translation_tables.cc b/chromeos/network/onc/onc_translation_tables.cc

index fb1621754761a8ef967281309a44c7c3139884a2..f33f333adad3e2b94e94325c6f37fd7efd100a61 100644

--- a/chromeos/network/onc/onc_translation_tables.cc

+++ b/chromeos/network/onc/onc_translation_tables.cc

@@ -337,7 +337,8 @@ const FieldTranslationEntry kCellularDeviceTable[] = {

// This field is converted during translation, see onc_translator_*.

// { ::onc::cellular::kFoundNetworks, shill::kFoundNetworksProperty},

{ ::onc::cellular::kHardwareRevision, shill::kHardwareRevisionProperty},

- { ::onc::cellular::kHomeProvider, shill::kHomeProviderProperty},

+ // This field is converted during translation, see onc_translator_*.

+ // { ::onc::cellular::kHomeProvider, shill::kHomeProviderProperty},

{ ::onc::cellular::kICCID, shill::kIccidProperty},

{ ::onc::cellular::kIMEI, shill::kImeiProperty},

{ ::onc::cellular::kIMSI, shill::kImsiProperty},