Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Side by Side Diff: chromeos/network/onc/onc_translation_tables.cc

Issue 949783003: Add WiMAX to ONC validation list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add and fix tests Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/network/onc/onc_translation_tables.h" 5 #include "chromeos/network/onc/onc_translation_tables.h"
6 6
7 #include <cstddef> 7 #include <cstddef>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "components/onc/onc_constants.h" 10 #include "components/onc/onc_constants.h"
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 // This field is converted during translation, see onc_translator_*. 330 // This field is converted during translation, see onc_translator_*.
331 // { ::onc::cellular::kAPNList, shill::kCellularApnListProperty}, 331 // { ::onc::cellular::kAPNList, shill::kCellularApnListProperty},
332 { ::onc::cellular::kAllowRoaming, shill::kCellularAllowRoamingProperty}, 332 { ::onc::cellular::kAllowRoaming, shill::kCellularAllowRoamingProperty},
333 { ::onc::cellular::kCarrier, shill::kCarrierProperty}, 333 { ::onc::cellular::kCarrier, shill::kCarrierProperty},
334 { ::onc::cellular::kESN, shill::kEsnProperty}, 334 { ::onc::cellular::kESN, shill::kEsnProperty},
335 { ::onc::cellular::kFamily, shill::kTechnologyFamilyProperty}, 335 { ::onc::cellular::kFamily, shill::kTechnologyFamilyProperty},
336 { ::onc::cellular::kFirmwareRevision, shill::kFirmwareRevisionProperty}, 336 { ::onc::cellular::kFirmwareRevision, shill::kFirmwareRevisionProperty},
337 // This field is converted during translation, see onc_translator_*. 337 // This field is converted during translation, see onc_translator_*.
338 // { ::onc::cellular::kFoundNetworks, shill::kFoundNetworksProperty}, 338 // { ::onc::cellular::kFoundNetworks, shill::kFoundNetworksProperty},
339 { ::onc::cellular::kHardwareRevision, shill::kHardwareRevisionProperty}, 339 { ::onc::cellular::kHardwareRevision, shill::kHardwareRevisionProperty},
340 { ::onc::cellular::kHomeProvider, shill::kHomeProviderProperty}, 340 // This field is converted during translation, see onc_translator_*.
341 // { ::onc::cellular::kHomeProvider, shill::kHomeProviderProperty},
341 { ::onc::cellular::kICCID, shill::kIccidProperty}, 342 { ::onc::cellular::kICCID, shill::kIccidProperty},
342 { ::onc::cellular::kIMEI, shill::kImeiProperty}, 343 { ::onc::cellular::kIMEI, shill::kImeiProperty},
343 { ::onc::cellular::kIMSI, shill::kImsiProperty}, 344 { ::onc::cellular::kIMSI, shill::kImsiProperty},
344 { ::onc::cellular::kManufacturer, shill::kManufacturerProperty}, 345 { ::onc::cellular::kManufacturer, shill::kManufacturerProperty},
345 { ::onc::cellular::kMDN, shill::kMdnProperty}, 346 { ::onc::cellular::kMDN, shill::kMdnProperty},
346 { ::onc::cellular::kMEID, shill::kMeidProperty}, 347 { ::onc::cellular::kMEID, shill::kMeidProperty},
347 { ::onc::cellular::kMIN, shill::kMinProperty}, 348 { ::onc::cellular::kMIN, shill::kMinProperty},
348 { ::onc::cellular::kModelID, shill::kModelIDProperty}, 349 { ::onc::cellular::kModelID, shill::kModelIDProperty},
349 { ::onc::cellular::kPRLVersion, shill::kPRLVersionProperty}, 350 { ::onc::cellular::kPRLVersion, shill::kPRLVersionProperty},
350 { ::onc::cellular::kProviderRequiresRoaming, 351 { ::onc::cellular::kProviderRequiresRoaming,
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 continue; 417 continue;
417 *onc_value = table[i].onc_value; 418 *onc_value = table[i].onc_value;
418 return true; 419 return true;
419 } 420 }
420 LOG(ERROR) << "Value '" << shill_value << "' cannot be translated to ONC"; 421 LOG(ERROR) << "Value '" << shill_value << "' cannot be translated to ONC";
421 return false; 422 return false;
422 } 423 }
423 424
424 } // namespace onc 425 } // namespace onc
425 } // namespace chromeos 426 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698