Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: src/full-codegen.cc

Issue 949763003: WIP: new.target (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | src/messages.js » ('j') | src/scopes.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen.cc
diff --git a/src/full-codegen.cc b/src/full-codegen.cc
index 6f43497a799ed73d0d6b1c6845d6bfcb400fb36f..b734f11dd7987645c623a5c0a44932cc8166f5f4 100644
--- a/src/full-codegen.cc
+++ b/src/full-codegen.cc
@@ -843,7 +843,7 @@ bool FullCodeGenerator::ValidateSuperCall(Call* expr) {
Variable* new_target_var = scope()->DeclarationScope()->new_target_var();
if (new_target_var == nullptr) {
// TODO(dslomov): this is not exactly correct, the spec requires us
- // to execute the constructor and only fail when an assigment to 'this'
+ // to execute the constructor and only fail when an assignment to 'this'
Dmitry Lomov (no reviews) 2015/02/25 11:28:40 I believe we can now kill this entire function and
arv (Not doing code reviews) 2015/02/25 14:47:24 That is unrelated to this CL. I'll remove it in an
// is attempted. Will implement once we have general new.target support,
// but also filed spec bug 3843 to make it an early error.
__ CallRuntime(Runtime::kThrowUnsupportedSuperError, 0);
« no previous file with comments | « src/flag-definitions.h ('k') | src/messages.js » ('j') | src/scopes.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698