WIP: new.target

src/full-codegen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/ast.h"
 #include "src/ast-numbering.h"
 #include "src/code-factory.h"
 #include "src/codegen.h"
@@ skipping 825 matching lines @@
 
 void FullCodeGenerator::VisitSuperReference(SuperReference* super) {
   __ CallRuntime(Runtime::kThrowUnsupportedSuperError, 0);
 }
 
 
 bool FullCodeGenerator::ValidateSuperCall(Call* expr) {
   Variable* new_target_var = scope()->DeclarationScope()->new_target_var();
   if (new_target_var == nullptr) {
     // TODO(dslomov): this is not exactly correct, the spec requires us
-    // to execute the constructor and only fail when an assigment to 'this'
+    // to execute the constructor and only fail when an assignment to 'this'

[Dmitry Lomov (no reviews), 2015/02/25 11:28:40]

I believe we can now kill this entire function and all its uses (since now the
parser guarantees that 'super(...)' only occurs where new.target is avaliable.

[arv (Not doing code reviews), 2015/02/25 14:47:24]

That is unrelated to this CL. I'll remove it in another CL.

     // is attempted. Will implement once we have general new.target support,
     // but also filed spec bug 3843 to make it an early error.
     __ CallRuntime(Runtime::kThrowUnsupportedSuperError, 0);
     RecordJSReturnSite(expr);
     context()->Plug(result_register());
     return false;
   }
   return true;
 }
 
@@ skipping 966 matching lines @@
   }
   codegen_->PrepareForBailoutForId(exit_id_, NO_REGISTERS);
   codegen_->scope_ = saved_scope_;
 }
 
 
 #undef __
 
 
 } }  // namespace v8::internal