Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 949683002: Web MIDI: running status should be reset on receiving a system message (Closed)

Created:
5 years, 10 months ago by Takashi Toyoshima
Modified:
5 years, 10 months ago
Reviewers:
yukawa
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: running status should be reset on receiving a system message Running status should be used only for channel voice messages, and it is recommented that the status is cleared on receiving system common messages including system exclusive messages. BUG=456780 TEST=media_unittests Committed: https://crrev.com/bb981086bf2cbb96351bd74ccbbed3cac4830e94 Cr-Commit-Position: refs/heads/master@{#317545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M media/midi/midi_message_queue.cc View 2 chunks +6 lines, -1 line 0 comments Download
M media/midi/midi_message_queue_unittest.cc View 3 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Takashi Toyoshima
Hi Yohei, I noticed a small compatibility issue on running status handling. Can you take ...
5 years, 10 months ago (2015-02-21 19:23:35 UTC) #2
yukawa
On 2015/02/21 19:23:35, Takashi Toyoshima (chromium) wrote: > Hi Yohei, > I noticed a small ...
5 years, 10 months ago (2015-02-22 08:07:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949683002/1
5 years, 10 months ago (2015-02-22 13:43:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61379)
5 years, 10 months ago (2015-02-22 13:45:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949683002/1
5 years, 10 months ago (2015-02-22 18:56:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61407)
5 years, 10 months ago (2015-02-22 18:58:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949683002/1
5 years, 10 months ago (2015-02-23 02:17:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61445)
5 years, 10 months ago (2015-02-23 02:20:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949683002/1
5 years, 10 months ago (2015-02-23 05:09:28 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 05:18:18 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 05:19:04 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb981086bf2cbb96351bd74ccbbed3cac4830e94
Cr-Commit-Position: refs/heads/master@{#317545}

Powered by Google App Engine
This is Rietveld 408576698