Web MIDI: running status should be reset on receiving a system message

media/midi/midi_message_queue_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/midi/midi_message_queue.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace media {
 namespace {
 
 const uint8 kGMOn[] = { 0xf0, 0x7e, 0x7f, 0x09, 0x01, 0xf7 };
 const uint8 kGSOn[] = {
   0xf0, 0x41, 0x10, 0x42, 0x12, 0x40, 0x00, 0x7f, 0x00, 0x41, 0xf7,
 };
 const uint8 kNoteOn[] = { 0x90, 0x3c, 0x7f };
 const uint8 kNoteOnWithRunningStatus[] = {
   0x90, 0x3c, 0x7f, 0x3c, 0x7f, 0x3c, 0x7f,
 };
 const uint8 kChannelPressure[] = { 0xd0, 0x01 };
 const uint8 kChannelPressureWithRunningStatus[] = {
   0xd0, 0x01, 0x01, 0x01,
 };
 const uint8 kTimingClock[] = { 0xf8 };
+const uint8 kMTCFrame[] = { 0xf1, 0x00 };
 const uint8 kBrokenData1[] = { 0x90 };
 const uint8 kBrokenData2[] = { 0xf7 };
 const uint8 kBrokenData3[] = { 0xf2, 0x00 };
 const uint8 kDataByte0[] = { 0x00 };
 
 template <typename T, size_t N>
 void Add(MidiMessageQueue* queue, const T(&array)[N]) {
   queue->Add(array, N);
 }
 
@@ skipping 99 matching lines @@
   EXPECT_MESSAGE(kGSOn, message);
   queue.Get(&message);
   EXPECT_MESSAGE(kTimingClock, message);
   queue.Get(&message);
   EXPECT_TRUE(message.empty())
       << "Running status must not be applied to real time messages";
 }
 
 TEST(MidiMessageQueueTest, RunningStatusEnabledWithRealTimeEvent) {
   MidiMessageQueue queue(true);
-  const uint8 kNoteOnWithRunningStatusWithkTimingClock[] = {
+  const uint8 kNoteOnWithRunningStatusWithTimingClock[] = {
     0x90, 0xf8, 0x3c, 0xf8, 0x7f, 0xf8, 0x3c, 0xf8, 0x7f, 0xf8, 0x3c, 0xf8,
     0x7f,
   };
-  Add(&queue, kNoteOnWithRunningStatusWithkTimingClock);
+  Add(&queue, kNoteOnWithRunningStatusWithTimingClock);
   std::vector<uint8> message;
   queue.Get(&message);
   EXPECT_MESSAGE(kTimingClock, message);
   queue.Get(&message);
   EXPECT_MESSAGE(kTimingClock, message);
   queue.Get(&message);
   EXPECT_MESSAGE(kNoteOn, message);
   queue.Get(&message);
   EXPECT_MESSAGE(kTimingClock, message);
   queue.Get(&message);
   EXPECT_MESSAGE(kTimingClock, message);
   queue.Get(&message);
   EXPECT_MESSAGE(kNoteOn, message);
   queue.Get(&message);
   EXPECT_MESSAGE(kTimingClock, message);
   queue.Get(&message);
   EXPECT_MESSAGE(kTimingClock, message);
   queue.Get(&message);
   EXPECT_MESSAGE(kNoteOn, message);
   queue.Get(&message);
   EXPECT_TRUE(message.empty());
 }
 
+TEST(MidiMessageQueueTest, RunningStatusEnabledWithSystemCommonMessage) {
+  MidiMessageQueue queue(true);
+  const uint8 kNoteOnWithRunningStatusWithSystemCommonMessage[] = {
+    0x90, 0x3c, 0x7f, 0xf1, 0x00, 0x3c, 0x7f, 0xf8, 0x90, 0x3c, 0x7f,
+  };
+  Add(&queue, kNoteOnWithRunningStatusWithSystemCommonMessage);
+  std::vector<uint8> message;
+  queue.Get(&message);
+  EXPECT_MESSAGE(kNoteOn, message);
+  queue.Get(&message);
+  EXPECT_MESSAGE(kMTCFrame, message);
+  queue.Get(&message);
+  EXPECT_MESSAGE(kTimingClock, message) << "Running status should be reset";
+  queue.Get(&message);
+  EXPECT_MESSAGE(kNoteOn, message);
+  queue.Get(&message);
+  EXPECT_TRUE(message.empty());
+}
+
 }  // namespace
 }  // namespace media