Support plugin version mid-portions with leading zeros.

Support plugin version mid-portions with leading zeros.

Now supported: 1.02.3.4
Remains unsupported: 01.2.3.4

BUG=460642
Committed: https://crrev.com/f15124923f9da90592b84573cb4299b4b8ddc11c
Cr-Commit-Position: refs/heads/master@{#317524}

[Will Harris, 2015-02-21 00:20:48]

wfh@chromium.org changed reviewers:
+ thakis@chromium.org

[Will Harris, 2015-02-21 00:34:59]

PTAL

[Nico, 2015-02-21 23:11:16]

Seems generally fine (I looked through the "prevent 032" history; it's been
around since https://codereview.chromium.org/19667, and `git log --
chrome/installer/util/version.cc` claims that that version.cc is from the
initial import.)

https://codereview.chromium.org/949573002/diff/1/base/version_unittest.cc
File base/version_unittest.cc (right):

https://codereview.chromium.org/949573002/diff/1/base/version_unittest.cc#new...
base/version_unittest.cc:53: {"02.1", 2, true},
Should we still disallow 0s on the first version component?

[Will Harris, 2015-02-22 00:37:37]

PTAL - added a few more test cases too.

https://codereview.chromium.org/949573002/diff/1/base/version_unittest.cc
File base/version_unittest.cc (right):

https://codereview.chromium.org/949573002/diff/1/base/version_unittest.cc#new...
base/version_unittest.cc:53: {"02.1", 2, true},
On 2015/02/21 23:11:16, Nico wrote:
> Should we still disallow 0s on the first version component?

yes I agree that makes most sense.

Done.

[Nico, 2015-02-22 01:16:32]

thanks!

https://codereview.chromium.org/949573002/diff/20001/base/version_unittest.cc
File base/version_unittest.cc (right):

https://codereview.chromium.org/949573002/diff/20001/base/version_unittest.cc...
base/version_unittest.cc:48: {"1.-1.0", 0, false},
can you add a row like 

  {"1.--1.0", 0, false},

too, please?

lgtm with that.

[Will Harris, 2015-02-22 01:20:34]

New patchsets have been uploaded after l-g-t-m from thakis@chromium.org

[Will Harris, 2015-02-22 01:21:25]

thanks!

https://codereview.chromium.org/949573002/diff/20001/base/version_unittest.cc
File base/version_unittest.cc (right):

https://codereview.chromium.org/949573002/diff/20001/base/version_unittest.cc...
base/version_unittest.cc:48: {"1.-1.0", 0, false},
On 2015/02/22 01:16:31, Nico wrote:
> can you add a row like 
> 
>   {"1.--1.0", 0, false},
> 
> too, please?
> 
> lgtm with that.

Done.

[Will Harris, 2015-02-22 01:21:37]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2015-02-22 01:22:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/949573002/40001

[commit-bot: I haz the power, 2015-02-22 05:41:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-22 05:42:27]

Patchset 3 (id:??) landed as
https://crrev.com/f15124923f9da90592b84573cb4299b4b8ddc11c
Cr-Commit-Position: refs/heads/master@{#317524}