Support plugin version mid-portions with leading zeros.

base/version_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/version.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
@@ skipping 29 matching lines @@
     {"  ", 0, false},
     {".", 0, false},
     {" . ", 0, false},
     {"0", 1, true},
     {"0.0", 2, true},
     {"65537.0", 0, false},
     {"-1.0", 0, false},
     {"1.-1.0", 0, false},
     {"+1.0", 0, false},
     {"1.+1.0", 0, false},
+    {"1+1.0", 0, false},
     {"1.0a", 0, false},
     {"1.2.3.4.5.6.7.8.9.0", 10, true},
-    {"02.1", 0, false},
+    {"02.1", 2, true},

[Nico, 2015/02/21 23:11:16]

Should we still disallow 0s on the first version component?

[Will Harris, 2015/02/22 00:37:37]

yes I agree that makes most sense.

Done.

     {"f.1", 0, false},
+    {"15.007.20011", 3, true},
   };
 
   for (size_t i = 0; i < arraysize(cases); ++i) {
     Version version(cases[i].input);
     EXPECT_EQ(cases[i].success, version.IsValid());
     if (cases[i].success)
       EXPECT_EQ(cases[i].parts, version.components().size());
   }
 }
 
 TEST(VersionTest, Compare) {
   static const struct version_compare {
     const char* lhs;
     const char* rhs;
     int expected;
   } cases[] = {
     {"1.0", "1.0", 0},
     {"1.0", "0.0", 1},
     {"1.0", "2.0", -1},
     {"1.0", "1.1", -1},
     {"1.1", "1.0", 1},
     {"1.0", "1.0.1", -1},
     {"1.1", "1.0.1", 1},
     {"1.1", "1.0.1", 1},
     {"1.0.0", "1.0", 0},
     {"1.0.3", "1.0.20", -1},
+    {"11.0.10", "15.007.20011", -1},
   };
   for (size_t i = 0; i < arraysize(cases); ++i) {
     Version lhs(cases[i].lhs);
     Version rhs(cases[i].rhs);
     EXPECT_EQ(lhs.CompareTo(rhs), cases[i].expected) <<
         cases[i].lhs << " ? " << cases[i].rhs;
 
     EXPECT_EQ(lhs.IsOlderThan(cases[i].rhs), (cases[i].expected == -1));
   }
 }
@@ skipping 42 matching lines @@
     {"*", false},
     {"*.2", false},
   };
   for (size_t i = 0; i < arraysize(cases); ++i) {
     EXPECT_EQ(Version::IsValidWildcardString(cases[i].version),
         cases[i].expected) << cases[i].version << "?" << cases[i].expected;
   }
 }
 
 }  // namespace