Rename DataReductionProxyStatisticsPrefs to DataReductionProxyCompressionStats

Rename DataReductionProxyStatisticsPrefs to DataReductionProxyCompressionStats

As the comment in data_reduction_proxy_statistics_prefs.h by bengr@,
rename DataReductionProxyStatisticsPrefs to DataReductionProxyCompressionStats
and related class. Rename the files also.

BUG=462845
R=bengr@chromium.org, jam@chromium.org

Committed: https://crrev.com/a0e8c4b6d24d023997323f7ce20df759739c351b
Cr-Commit-Position: refs/heads/master@{#323421}

[jam, 2015-02-26 16:23:16]

what do you want me to review?

[zhuoyu.qian, 2015-02-27 01:10:27]

On 2015/02/26 16:23:16, jam wrote:
> what do you want me to review?

Hi jam,
I'd like you to do a code review for
android_webview/browser/aw_browser_context.cc
Thank you.

[bengr, 2015-02-27 22:43:33]

Thanks for doing this. Along with changing the class name, you should also
change all comments and variable and method names that refer to statistics
prefs.

https://codereview.chromium.org/949533004/diff/1/components/data_reduction_pr...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
(right):

https://codereview.chromium.org/949533004/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h:49:
scoped_ptr<DataReductionProxyCompressionStats> statistics_prefs,
You'll want to change every variable name accordingly too.

https://codereview.chromium.org/949533004/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h:62:
// Constructs statistics prefs. This should not be called if a valid
"compression stats", here and below.

https://codereview.chromium.org/949533004/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h:69:
DataReductionProxyCompressionStats* statistics_prefs() const {
This function should be called compression_stats()

https://codereview.chromium.org/949533004/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h:70:
return statistics_prefs_.get();
compression_stats_

[bengr, 2015-02-27 22:44:09]

Also, please file a chromium bug that describes the issue and reference that bug
in the CL.

[zhuoyu.qian, 2015-02-28 06:16:03]

Patch has updated according bengr's comments above, PHAL.
Thank you.

https://codereview.chromium.org/949533004/diff/1/components/data_reduction_pr...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
(right):

https://codereview.chromium.org/949533004/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h:49:
scoped_ptr<DataReductionProxyCompressionStats> statistics_prefs,
On 2015/02/27 22:43:32, bengr wrote:
> You'll want to change every variable name accordingly too.

Done.

https://codereview.chromium.org/949533004/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h:62:
// Constructs statistics prefs. This should not be called if a valid
On 2015/02/27 22:43:32, bengr wrote:
> "compression stats", here and below.

Done.

https://codereview.chromium.org/949533004/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h:69:
DataReductionProxyCompressionStats* statistics_prefs() const {
On 2015/02/27 22:43:33, bengr wrote:
> This function should be called compression_stats()

Done.

https://codereview.chromium.org/949533004/diff/1/components/data_reduction_pr...
components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h:70:
return statistics_prefs_.get();
On 2015/02/27 22:43:33, bengr wrote:
> compression_stats_

Done.

[bengr, 2015-03-16 23:46:58]

lgtm. Please be careful when rebasing.

[zhuoyu.qian, 2015-03-17 03:32:22]

Hi jam,
There is a file need you to take a look at:
android_webview/browser/aw_browser_context.cc
Thank you.

[bengr, 2015-03-17 16:23:36]

On 2015/03/17 03:32:22, zhuoyu.qian wrote:
> Hi jam,
> There is a file need you to take a look at:
> android_webview/browser/aw_browser_context.cc
> Thank you.

I'd suggest sgurun@ as a reviewer for this file.

[sgurun-gerrit only, 2015-03-17 16:54:43]

On 2015/03/17 16:23:36, bengr wrote:
> On 2015/03/17 03:32:22, zhuoyu.qian wrote:
> > Hi jam,
> > There is a file need you to take a look at:
> > android_webview/browser/aw_browser_context.cc
> > Thank you.
> 
> I'd suggest sgurun@ as a reviewer for this file.

lgtm

[bengr, 2015-03-24 15:51:17]

Not lgtm. Please revert formatting changes that have nothing to do with the goal
of this CL. Don't rely on git cl format.

https://codereview.chromium.org/949533004/diff/40001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
(right):

https://codereview.chromium.org/949533004/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc:211:
list_pref_map_.get(data_reduction_proxy::prefs::
Please revert formatting changes that have nothing to do with the class rename.

[zhuoyu.qian, 2015-03-30 03:13:49]

I revert the format not related rename.
PTAL.

https://codereview.chromium.org/949533004/diff/40001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
(right):

https://codereview.chromium.org/949533004/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc:211:
list_pref_map_.get(data_reduction_proxy::prefs::
On 2015/03/24 15:51:17, bengr wrote:
> Please revert formatting changes that have nothing to do with the class
rename.

Done.

[bengr, 2015-03-31 16:57:48]

lgtm

[zhuoyu.qian, 2015-04-01 01:27:44]

The CQ bit was checked by zhuoyu.qian@samsung.com

[zhuoyu.qian, 2015-04-01 01:27:45]

The patchset sent to the CQ was uploaded after l-g-t-m from sgurun@chromium.org
Link to the patchset: https://codereview.chromium.org/949533004/#ps80001 (title:
" ")

[commit-bot: I haz the power, 2015-04-01 01:27:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/949533004/80001

[commit-bot: I haz the power, 2015-04-01 01:38:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-01 01:38:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[zhuoyu.qian, 2015-04-01 01:50:59]

zhuoyu.qian@samsung.com changed reviewers:
+ mmenke@chromium.org
- jam@chromium.org

[zhuoyu.qian, 2015-04-01 01:51:00]

Hi mmenke,
There is a file need you to take a look:
chrome/browser/ui/webui/net_internals/net_internals_ui.cc

[mmenke, 2015-04-01 14:24:23]

On 2015/04/01 01:51:00, zhuoyu.qian wrote:
> Hi mmenke,
> There is a file need you to take a look:
> chrome/browser/ui/webui/net_internals/net_internals_ui.cc

net_internals LGTM

[zhuoyu.qian, 2015-04-02 01:08:25]

The CQ bit was checked by zhuoyu.qian@samsung.com

[commit-bot: I haz the power, 2015-04-02 01:09:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/949533004/80001

[commit-bot: I haz the power, 2015-04-02 01:21:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-02 01:21:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[zhuoyu.qian, 2015-04-02 01:42:10]

The CQ bit was checked by zhuoyu.qian@samsung.com

[zhuoyu.qian, 2015-04-02 01:42:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sgurun@chromium.org,
bengr@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/949533004/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-02 01:43:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/949533004/100001

[commit-bot: I haz the power, 2015-04-02 03:38:20]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-04-03 20:22:24]

Patchset 6 (id:??) landed as
https://crrev.com/a0e8c4b6d24d023997323f7ce20df759739c351b
Cr-Commit-Position: refs/heads/master@{#323421}