Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 949533004: Rename DataReductionProxyStatisticsPrefs to DataReductionProxyCompressionStats (Closed)

Created:
5 years, 10 months ago by zhuoyu.qian
Modified:
5 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DataReductionProxyStatisticsPrefs to DataReductionProxyCompressionStats As the comment in data_reduction_proxy_statistics_prefs.h by bengr@, rename DataReductionProxyStatisticsPrefs to DataReductionProxyCompressionStats and related class. Rename the files also. BUG=462845 R=bengr@chromium.org, jam@chromium.org Committed: https://crrev.com/a0e8c4b6d24d023997323f7ce20df759739c351b Cr-Commit-Position: refs/heads/master@{#323421}

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : revert format #

Patch Set 5 : #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -838 lines) Patch
M android_webview/browser/aw_browser_context.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc View 1 2 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 2 3 4 5 2 chunks +7 lines, -5 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M components/data_reduction_proxy.gypi View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
A + components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.h View 1 2 3 4 chunks +11 lines, -12 lines 0 comments Download
A + components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc View 1 2 3 13 chunks +25 lines, -25 lines 0 comments Download
A + components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc View 1 2 3 13 chunks +43 lines, -43 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.cc View 1 2 3 9 chunks +16 lines, -18 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc View 1 2 3 4 32 chunks +34 lines, -34 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 1 2 3 4 5 3 chunks +8 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h View 1 4 chunks +8 lines, -9 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc View 1 2 6 chunks +12 lines, -12 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.h View 1 2 1 chunk +0 lines, -120 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs.cc View 1 2 1 chunk +0 lines, -240 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics_prefs_unittest.cc View 1 2 1 chunk +0 lines, -264 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc View 1 2 3 4 5 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 30 (8 generated)
zhuoyu.qian
5 years, 10 months ago (2015-02-26 01:29:13 UTC) #1
jam
what do you want me to review?
5 years, 10 months ago (2015-02-26 16:23:16 UTC) #2
zhuoyu.qian
On 2015/02/26 16:23:16, jam wrote: > what do you want me to review? Hi jam, ...
5 years, 10 months ago (2015-02-27 01:10:27 UTC) #3
bengr
Thanks for doing this. Along with changing the class name, you should also change all ...
5 years, 9 months ago (2015-02-27 22:43:33 UTC) #4
bengr
Also, please file a chromium bug that describes the issue and reference that bug in ...
5 years, 9 months ago (2015-02-27 22:44:09 UTC) #5
zhuoyu.qian
Patch has updated according bengr's comments above, PHAL. Thank you. https://codereview.chromium.org/949533004/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h File components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h (right): https://codereview.chromium.org/949533004/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h#newcode49 ...
5 years, 9 months ago (2015-02-28 06:16:03 UTC) #6
bengr
lgtm. Please be careful when rebasing.
5 years, 9 months ago (2015-03-16 23:46:58 UTC) #7
zhuoyu.qian
Hi jam, There is a file need you to take a look at: android_webview/browser/aw_browser_context.cc Thank ...
5 years, 9 months ago (2015-03-17 03:32:22 UTC) #8
bengr
On 2015/03/17 03:32:22, zhuoyu.qian wrote: > Hi jam, > There is a file need you ...
5 years, 9 months ago (2015-03-17 16:23:36 UTC) #9
sgurun-gerrit only
On 2015/03/17 16:23:36, bengr wrote: > On 2015/03/17 03:32:22, zhuoyu.qian wrote: > > Hi jam, ...
5 years, 9 months ago (2015-03-17 16:54:43 UTC) #10
bengr
Not lgtm. Please revert formatting changes that have nothing to do with the goal of ...
5 years, 9 months ago (2015-03-24 15:51:17 UTC) #11
zhuoyu.qian
I revert the format not related rename. PTAL. https://codereview.chromium.org/949533004/diff/40001/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc (right): https://codereview.chromium.org/949533004/diff/40001/components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc#newcode211 components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc:211: list_pref_map_.get(data_reduction_proxy::prefs:: ...
5 years, 8 months ago (2015-03-30 03:13:49 UTC) #12
bengr
lgtm
5 years, 8 months ago (2015-03-31 16:57:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949533004/80001
5 years, 8 months ago (2015-04-01 01:27:59 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/53155)
5 years, 8 months ago (2015-04-01 01:38:52 UTC) #18
zhuoyu.qian
Hi mmenke, There is a file need you to take a look: chrome/browser/ui/webui/net_internals/net_internals_ui.cc
5 years, 8 months ago (2015-04-01 01:51:00 UTC) #20
mmenke
On 2015/04/01 01:51:00, zhuoyu.qian wrote: > Hi mmenke, > There is a file need you ...
5 years, 8 months ago (2015-04-01 14:24:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949533004/80001
5 years, 8 months ago (2015-04-02 01:09:19 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/53512)
5 years, 8 months ago (2015-04-02 01:21:03 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949533004/100001
5 years, 8 months ago (2015-04-02 01:43:29 UTC) #28
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-02 03:38:20 UTC) #29
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:22:24 UTC) #30
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/a0e8c4b6d24d023997323f7ce20df759739c351b
Cr-Commit-Position: refs/heads/master@{#323421}

Powered by Google App Engine
This is Rietveld 408576698