Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

Issue 949533004: Rename DataReductionProxyStatisticsPrefs to DataReductionProxyCompressionStats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
index 5343635bebb1ae74a9488036be7ebbaa1b81b1fd..1760c10be9d8b32f5a65fb2429f209501b14a82a 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h
@@ -32,8 +32,7 @@ typedef base::Callback<void(const std::string&, const net::URLRequestStatus&)>
FetcherResponseCallback;
class DataReductionProxySettings;
-class DataReductionProxyStatisticsPrefs;
-
+class DataReductionProxyCompressionStats;
// Contains and initializes all Data Reduction Proxy objects that have a
// lifetime based on the UI thread.
@@ -42,11 +41,11 @@ class DataReductionProxyService : public base::NonThreadSafe,
public:
// The caller must ensure that |settings| and |request_context| remain alive
// for the lifetime of the |DataReductionProxyService| instance. This instance
- // will take ownership of |statistics_prefs|.
+ // will take ownership of |compression_stats|.
// TODO(jeremyim): DataReductionProxyService should own
// DataReductionProxySettings and not vice versa.
DataReductionProxyService(
- scoped_ptr<DataReductionProxyStatisticsPrefs> statistics_prefs,
+ scoped_ptr<DataReductionProxyCompressionStats> compression_stats,
DataReductionProxySettings* settings,
net::URLRequestContextGetter* request_context_getter);
@@ -60,15 +59,15 @@ class DataReductionProxyService : public base::NonThreadSafe,
virtual void SecureProxyCheck(const GURL& secure_proxy_check_url,
FetcherResponseCallback fetcher_callback);
- // Constructs statistics prefs. This should not be called if a valid
- // statistics prefs is passed into the constructor.
+ // Constructs compression stats. This should not be called if a valid
+ // compression stats is passed into the constructor.
void EnableCompressionStatisticsLogging(
PrefService* prefs,
scoped_refptr<base::SequencedTaskRunner> ui_task_runner,
const base::TimeDelta& commit_delay);
- DataReductionProxyStatisticsPrefs* statistics_prefs() const {
- return statistics_prefs_.get();
+ DataReductionProxyCompressionStats* compression_stats() const {
+ return compression_stats_.get();
}
DataReductionProxySettings* settings() const {
@@ -94,7 +93,7 @@ class DataReductionProxyService : public base::NonThreadSafe,
FetcherResponseCallback fetcher_callback_;
// Tracks compression statistics to be displayed to the user.
- scoped_ptr<DataReductionProxyStatisticsPrefs> statistics_prefs_;
+ scoped_ptr<DataReductionProxyCompressionStats> compression_stats_;
DataReductionProxySettings* settings_;

Powered by Google App Engine
This is Rietveld 408576698