content/browser/web_contents/web_contents_view_aura.cc - Issue 949473002: Avoid unnecessary casts in NavigationControllerImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 949473002: Avoid unnecessary casts in NavigationControllerImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/browser/web_contents/web_contents_view_aura_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_view_aura.cc

diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc

index 83f64cb0dbbc916adfbbebca7a7a21c9f6f422df..dc4c5352c7789f9b4c41958954da4d5ed7d61b3d 100644

--- a/content/browser/web_contents/web_contents_view_aura.cc

+++ b/content/browser/web_contents/web_contents_view_aura.cc

@@ -126,11 +126,9 @@ class OverscrollWindowDelegate : public aura_extra::ImageWindowDelegate {

const NavigationControllerImpl& controller = web_contents->GetController();

const NavigationEntryImpl* entry = NULL;

if (ShouldNavigateForward(controller, overscroll_mode)) {

- entry = NavigationEntryImpl::FromNavigationEntry(

- controller.GetEntryAtOffset(1));

+ entry = controller.GetEntryAtOffset(1);

} else if (ShouldNavigateBack(controller, overscroll_mode)) {

- entry = NavigationEntryImpl::FromNavigationEntry(

- controller.GetEntryAtOffset(-1));

+ entry = controller.GetEntryAtOffset(-1);

}

gfx::Image image;