Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 949333002: Revert of Implement NativeViewAccessibilityWin using AXPlatformNodeWin. (Closed)

Created:
5 years, 10 months ago by DaleCurtis
Modified:
5 years, 10 months ago
CC:
aboxhall+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, plundblad+watch_chromium.org, tfarina, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement NativeViewAccessibilityWin using AXPlatformNodeWin. (patchset #17 id:320001 of https://codereview.chromium.org/909143003/) Reason for revert: Broke the Windows GN builder: http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/5049/steps/compile/logs/stdio Original issue's description: > Implement NativeViewAccessibilityWin using AXPlatformNodeWin. > > AXPlatformNodeWin is an implementation of Windows accessibility APIs > that doesn't know anything about content/ or ui/views/ - it just > exposes an abstract tree of AXNodeData nodes and uses a delegate > interface for everything else. > > This patch completely removes the Windows-specific views accessibility > code and implements it using AXPlatformNodeWin instead. A future > step will be to do the same with BrowserAccessibilityWin in content/. > > This patch also includes a new unit test for AXPlatformNodeWin, > since it's now possible to test it without any views or web > content code. Hooray! > > BUG=457564 > > Committed: https://crrev.com/f12318afda4d5bfd2f8a48eda4f0d7107e11f400 > Cr-Commit-Position: refs/heads/master@{#317878} TBR=nektar@chromium.org,dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457564 Committed: https://crrev.com/cc09a8673f96f988026bd069f9509f0c0cec569b Cr-Commit-Position: refs/heads/master@{#317883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2069 lines, -2571 lines) Patch
M ui/accessibility/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/accessibility/accessibility.gyp View 3 chunks +3 lines, -22 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node.h View 2 chunks +1 line, -23 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.h View 2 chunks +2 lines, -39 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.cc View 2 chunks +38 lines, -259 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_delegate.h View 1 chunk +4 lines, -50 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 4 chunks +2 lines, -12 lines 0 comments Download
D ui/accessibility/platform/ax_platform_node_win.h View 1 chunk +0 lines, -335 lines 0 comments Download
D ui/accessibility/platform/ax_platform_node_win.cc View 1 chunk +0 lines, -983 lines 0 comments Download
D ui/accessibility/platform/ax_platform_node_win_unittest.cc View 1 chunk +0 lines, -372 lines 0 comments Download
D ui/accessibility/platform/test_ax_node_wrapper.h View 1 chunk +0 lines, -53 lines 0 comments Download
D ui/accessibility/platform/test_ax_node_wrapper.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility.h View 1 chunk +14 lines, -29 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility.cc View 2 chunks +23 lines, -185 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_win.h View 1 chunk +425 lines, -4 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_win.cc View 3 chunks +1520 lines, -27 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_win_unittest.cc View 3 chunks +29 lines, -36 lines 0 comments Download
M ui/views/controls/webview/webview.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
DaleCurtis
Created Revert of Implement NativeViewAccessibilityWin using AXPlatformNodeWin.
5 years, 10 months ago (2015-02-24 21:10:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949333002/1
5 years, 10 months ago (2015-02-24 21:11:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 21:13:00 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 21:13:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc09a8673f96f988026bd069f9509f0c0cec569b
Cr-Commit-Position: refs/heads/master@{#317883}

Powered by Google App Engine
This is Rietveld 408576698