tests/presubmit_unittest.py - Issue 949273002: Add ability to specify and run post upload hooks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/presubmit_unittest.py

Issue 949273002: Add ability to specify and run post upload hooks (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Fix tests and cleanup Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/presubmit_unittest.py

diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py

index 4be5daffeb0653989cc74564c29688d94bf8dcf8..ae373742f27e99ab0fc8791eb036c9d30a4490cc 100755

--- a/tests/presubmit_unittest.py

+++ b/tests/presubmit_unittest.py

@@ -163,9 +163,11 @@ class PresubmitUnittest(PresubmitTestsBase):

_INHERIT_SETTINGS = 'inherit-review-settings-ok'

def testMembersChanged(self):

+ self.maxDiff = None

self.mox.ReplayAll()

members = [

- 'AffectedFile', 'Change', 'DoGetTrySlaves', 'DoPresubmitChecks',

+ 'AffectedFile', 'Change', 'DoGetTrySlaves',

+ 'DoPostUploadExecuter', 'DoPresubmitChecks', 'GetPostUploadExecuter',

'GetTrySlavesExecuter', 'GitAffectedFile', 'CallCommand', 'CommandData',

'GitChange', 'InputApi', 'ListRelevantPresubmitFiles', 'Main',

'NonexistantCannedCheckFilter', 'OutputApi', 'ParseFiles',

« presubmit_support.py ('K') | « tests/git_cl_test.py ('k') | no next file » | no next file with comments »