Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Unified Diff: Source/modules/webdatabase/SQLTransaction.h

Issue 949193002: [bindings] Remove SQLTransaction's usage of custom binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding null check for arguments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webdatabase/SQLTransaction.h
diff --git a/Source/modules/webdatabase/SQLTransaction.h b/Source/modules/webdatabase/SQLTransaction.h
index c104b60c5743824b4d40dbdf29834bf7152e8189..998fabb4a64a56ee7f69afadd103c7d5a7217155 100644
--- a/Source/modules/webdatabase/SQLTransaction.h
+++ b/Source/modules/webdatabase/SQLTransaction.h
@@ -29,6 +29,7 @@
#ifndef SQLTransaction_h
#define SQLTransaction_h
+#include "bindings/core/v8/Nullable.h"
#include "bindings/core/v8/ScriptWrappable.h"
#include "modules/webdatabase/SQLStatement.h"
#include "modules/webdatabase/SQLTransactionStateMachine.h"
@@ -45,6 +46,7 @@ class SQLTransactionBackend;
class SQLTransactionCallback;
class SQLTransactionErrorCallback;
class SQLValue;
+class ScriptValue;
class VoidCallback;
class SQLTransaction final
@@ -60,8 +62,9 @@ public:
void performPendingCallback();
- void executeSQL(const String& sqlStatement, const Vector<SQLValue>& arguments,
+ void executeSql(const String& sqlStatement, const Nullable<Vector<ScriptValue>>& arguments,
SQLStatementCallback*, SQLStatementErrorCallback*, ExceptionState&);
+ void executeSql(const String& sqlStatement, ExceptionState&);
Database* database() { return m_database.get(); }

Powered by Google App Engine
This is Rietveld 408576698