Source/modules/webdatabase/InspectorDatabaseAgent.cpp - Issue 949193002: [bindings] Remove SQLTransaction's usage of custom binding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webdatabase/InspectorDatabaseAgent.cpp

Issue 949193002: [bindings] Remove SQLTransaction's usage of custom binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding null check for arguments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/modules/v8/custom/custom.gypi ('k') | Source/modules/webdatabase/SQLTransaction.h » ('j') | Source/modules/webdatabase/SQLTransaction.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/webdatabase/InspectorDatabaseAgent.cpp

diff --git a/Source/modules/webdatabase/InspectorDatabaseAgent.cpp b/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

index 666ffb112b25eedc9c8c332aac6d55a59627b733..f3fa0fd084321dbd5d3daa6af408a04104648ff6 100644

--- a/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

+++ b/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

@@ -159,10 +159,9 @@ public:

if (!m_requestCallback->isActive())

return true;

- Vector<SQLValue> sqlValues;

SQLStatementCallback* callback = StatementCallback::create(m_requestCallback.get());

SQLStatementErrorCallback* errorCallback = StatementErrorCallback::create(m_requestCallback.get());

- transaction->executeSQL(m_sqlStatement, sqlValues, callback, errorCallback, IGNORE_EXCEPTION);

+ transaction->executeSql(m_sqlStatement, Vector<ScriptValue>(), callback, errorCallback, IGNORE_EXCEPTION);

return true;

}

private: