Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: Source/modules/webdatabase/InspectorDatabaseAgent.cpp

Issue 949193002: [bindings] Remove SQLTransaction's usage of custom binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Using NativeValueTraits Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/modules/v8/v8.gypi ('k') | Source/modules/webdatabase/SQLTransaction.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webdatabase/InspectorDatabaseAgent.cpp
diff --git a/Source/modules/webdatabase/InspectorDatabaseAgent.cpp b/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
index 666ffb112b25eedc9c8c332aac6d55a59627b733..aa4cc2cbd766c30d361768fede72dbc97edd7706 100644
--- a/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
+++ b/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
@@ -30,6 +30,7 @@
#include "modules/webdatabase/InspectorDatabaseAgent.h"
#include "bindings/core/v8/ExceptionStatePlaceholder.h"
+#include "bindings/core/v8/V8Binding.h"
#include "core/frame/LocalFrame.h"
#include "core/html/VoidCallback.h"
#include "core/inspector/InspectorState.h"
@@ -159,10 +160,9 @@ public:
if (!m_requestCallback->isActive())
return true;
- Vector<SQLValue> sqlValues;
SQLStatementCallback* callback = StatementCallback::create(m_requestCallback.get());
SQLStatementErrorCallback* errorCallback = StatementErrorCallback::create(m_requestCallback.get());
- transaction->executeSQL(m_sqlStatement, sqlValues, callback, errorCallback, IGNORE_EXCEPTION);
+ transaction->executeSql(ScriptState::current(v8::Isolate::GetCurrent()), m_sqlStatement, Vector<ScriptValue>(), callback, errorCallback, IGNORE_EXCEPTION);
vivekg 2015/03/06 14:15:13 Is there a way to avoid using the v8::Isolate here
vivekg 2015/03/06 14:19:44 Also I could see its usage at these many places he
Jens Widell 2015/03/06 14:26:03 One way to avoid it would be to keep the old execu
return true;
}
private:
« no previous file with comments | « Source/bindings/modules/v8/v8.gypi ('k') | Source/modules/webdatabase/SQLTransaction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698