[bindings] Remove SQLTransaction's usage of custom binding.

Source/modules/webdatabase/InspectorDatabaseAgent.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 12 matching lines @@
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "modules/webdatabase/InspectorDatabaseAgent.h"
 
 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
+#include "bindings/core/v8/V8Binding.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/VoidCallback.h"
 #include "core/inspector/InspectorState.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/page/Page.h"
 #include "modules/webdatabase/Database.h"
 #include "modules/webdatabase/DatabaseClient.h"
 #include "modules/webdatabase/InspectorDatabaseResource.h"
 #include "modules/webdatabase/SQLError.h"
 #include "modules/webdatabase/SQLResultSet.h"
@@ skipping 109 matching lines @@
     {
         visitor->trace(m_requestCallback);
         SQLTransactionCallback::trace(visitor);
     }
 
     virtual bool handleEvent(SQLTransaction* transaction) override
     {
         if (!m_requestCallback->isActive())
             return true;
 
-        Vector<SQLValue> sqlValues;
         SQLStatementCallback* callback = StatementCallback::create(m_requestCallback.get());
         SQLStatementErrorCallback* errorCallback = StatementErrorCallback::create(m_requestCallback.get());
-        transaction->executeSQL(m_sqlStatement, sqlValues, callback, errorCallback, IGNORE_EXCEPTION);
+        transaction->executeSql(ScriptState::current(v8::Isolate::GetCurrent()), m_sqlStatement, Vector<ScriptValue>(), callback, errorCallback, IGNORE_EXCEPTION);

[vivekg, 2015/03/06 14:15:13]

Is there a way to avoid using the v8::Isolate here? I am not quite sure about it
hence parked it here. WDYT?

[vivekg, 2015/03/06 14:19:44]

Also I could see its usage at these many places here [1]. So is it ok to have it
here as is?

[1]
https://code.google.com/p/chromium/codesearch#search/&q=v8::Isolate::GetCurre...

[Jens Widell, 2015/03/06 14:26:03]

One way to avoid it would be to keep the old executeSQL() function (with
unchanged signature), and use that from here and from the new executeSql()
method.

         return true;
     }
 private:
     TransactionCallback(const String& sqlStatement, PassRefPtrWillBeRawPtr<ExecuteSQLCallback> requestCallback)
         : m_sqlStatement(sqlStatement)
         , m_requestCallback(requestCallback) { }
     String m_sqlStatement;
     RefPtrWillBeMember<ExecuteSQLCallback> m_requestCallback;
 };
 
@@ skipping 165 matching lines @@
 
 DEFINE_TRACE(InspectorDatabaseAgent)
 {
 #if ENABLE(OILPAN)
     visitor->trace(m_resources);
 #endif
     InspectorBaseAgent::trace(visitor);
 }
 
 } // namespace blink