Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: sky/engine/core/html/HTMLIFrameElement.cpp

Issue 948943002: Gets HTMLIFrameElement::embedViewManagerClient to work with dart (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/html/HTMLIFrameElement.h ('k') | sky/engine/core/html/HTMLIFrameElement.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/HTMLIFrameElement.cpp
diff --git a/sky/engine/core/html/HTMLIFrameElement.cpp b/sky/engine/core/html/HTMLIFrameElement.cpp
index de92eef7b89ccfd30a06c5a7d182989cdc89340a..edbbc748a1b09dd3326a4d56259dab3c4bd63897 100644
--- a/sky/engine/core/html/HTMLIFrameElement.cpp
+++ b/sky/engine/core/html/HTMLIFrameElement.cpp
@@ -10,6 +10,7 @@
#include "sky/engine/core/html/parser/HTMLParserIdioms.h"
#include "sky/engine/core/loader/FrameLoaderClient.h"
#include "sky/engine/core/rendering/RenderIFrame.h"
+#include "sky/engine/tonic/mojo_converter.h"
namespace blink {
@@ -79,14 +80,13 @@ PassRefPtr<DartValue> HTMLIFrameElement::takeExposedServicesHandle(DartState*)
return DartValue::Create();
}
-void HTMLIFrameElement::embedViewManagerClient(DartValue* client) {
+void HTMLIFrameElement::embedViewManagerClient(RefPtr<DartValue> client)
+{
if (!m_contentView)
return;
- // TODO(dart)
- // mojo::MessagePipeHandle handle;
- // if (gin::ConvertFromV8(client.isolate(), client.v8Value(), &handle))
- // m_contentView->Embed(mojo::MakeProxy<mojo::ViewManagerClient>(mojo::MakeScopedHandle(handle)));
+ m_contentView->Embed(mojo::MakeProxy<mojo::ViewManagerClient>(
+ DartConverter<mojo::ScopedMessagePipeHandle>::FromDart(client->dart_value())));
}
void HTMLIFrameElement::navigateView()
« no previous file with comments | « sky/engine/core/html/HTMLIFrameElement.h ('k') | sky/engine/core/html/HTMLIFrameElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698