sky/engine/core/html/HTMLIFrameElement.h - Issue 948943002: Gets HTMLIFrameElement::embedViewManagerClient to work with dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/html/HTMLIFrameElement.h

Issue 948943002: Gets HTMLIFrameElement::embedViewManagerClient to work with dart (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/html/HTMLIFrameElement.h

diff --git a/sky/engine/core/html/HTMLIFrameElement.h b/sky/engine/core/html/HTMLIFrameElement.h

index 640840c795bec0d3132ab2f127ff3db129c4de0e..a0f46cc7da64149f4bd0733bc2dea8840012e0c4 100644

--- a/sky/engine/core/html/HTMLIFrameElement.h

+++ b/sky/engine/core/html/HTMLIFrameElement.h

@@ -28,7 +28,7 @@ public:

PassRefPtr<DartValue> takeServicesHandle(DartState*);

PassRefPtr<DartValue> takeExposedServicesHandle(DartState*);

- void embedViewManagerClient(DartValue* client);

+ void embedViewManagerClient(RefPtr<DartValue> client);

private:

explicit HTMLIFrameElement(Document&);

« no previous file with comments | « no previous file | sky/engine/core/html/HTMLIFrameElement.cpp » ('j') | no next file with comments »