Gets HTMLIFrameElement::embedViewManagerClient to work with dart

Gets HTMLIFrameElement::embedViewManagerClient to work with dart

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/761cc174d0e2c962ea16267fb76ef90627ee5332

[sky, 2015-02-23 22:09:34]

https://codereview.chromium.org/948943002/diff/1/sky/viewer/internals.cc
File sky/viewer/internals.cc (right):

https://codereview.chromium.org/948943002/diff/1/sky/viewer/internals.cc#newc...
sky/viewer/internals.cc:53: void RenderTreeAsText(Dart_NativeArguments args) {
I reorder these to be be alphabetical. I can easily undo this part if you think
alphabetizing is worth it here.

[sky, 2015-02-23 22:25:43]

sky@chromium.org changed reviewers:
+ abarth@chromium.org
- abart@chromium.org

[sky, 2015-02-23 22:25:51]

This time to the right person.

[abarth-chromium, 2015-02-23 22:29:37]

abarth@chromium.org changed reviewers:
+ abart@chromium.org

[abarth-chromium, 2015-02-23 22:29:38]

https://codereview.chromium.org/948943002/diff/1/sky/engine/tonic/dart_conver...
File sky/engine/tonic/dart_converter.h (right):

https://codereview.chromium.org/948943002/diff/1/sky/engine/tonic/dart_conver...
sky/engine/tonic/dart_converter.h:287: };
Please move this declaration to a separate header file, for example
sky/engine/tonic/mojo_converter.h

https://codereview.chromium.org/948943002/diff/1/sky/tests/services/iframe-em...
File sky/tests/services/iframe-embed-vmc.sky (right):

https://codereview.chromium.org/948943002/diff/1/sky/tests/services/iframe-em...
sky/tests/services/iframe-embed-vmc.sky:12: import 'dart:sky.internals' as
internals;
Please alphabetize these imports.

https://codereview.chromium.org/948943002/diff/1/sky/viewer/internals.cc
File sky/viewer/internals.cc (right):

https://codereview.chromium.org/948943002/diff/1/sky/viewer/internals.cc#newc...
sky/viewer/internals.cc:40:
DartConverter<mojo::ScopedMessagePipeHandle>::ToDart(handle.Pass()));
You should add a SetReturnValue function to
DartConverter<mojo::ScopedMessagePipeHandle>

https://codereview.chromium.org/948943002/diff/1/sky/viewer/internals.cc#newc...
sky/viewer/internals.cc:53: void RenderTreeAsText(Dart_NativeArguments args) {
On 2015/02/23 at 22:09:33, sky wrote:
> I reorder these to be be alphabetical. I can easily undo this part if you
think alphabetizing is worth it here.

That's great, thanks!

https://codereview.chromium.org/948943002/diff/1/sky/viewer/internals.cc#newc...
sky/viewer/internals.cc:74: {"connectToService", ConnectToService, 2},
Why do you need connectToService?  Can't you just use the shell handle to do
that?  For example, embedder.connectToService(...) from embedder.dart ?

[sky, 2015-02-23 22:38:57]

https://codereview.chromium.org/948943002/diff/1/sky/viewer/internals.cc
File sky/viewer/internals.cc (right):

https://codereview.chromium.org/948943002/diff/1/sky/viewer/internals.cc#newc...
sky/viewer/internals.cc:74: {"connectToService", ConnectToService, 2},
On 2015/02/23 22:29:37, abarth wrote:
> Why do you need connectToService?  Can't you just use the shell handle to do
> that?  For example, embedder.connectToService(...) from embedder.dart ?

That can certainly be done. I was assuming we wanted
Internals::ConnectToService() since this class exposes it already and that is
what the test had been using. Which do you prefer?

[abarth-chromium, 2015-02-23 22:43:20]

On 2015/02/23 at 22:38:57, sky wrote:
> That can certainly be done. I was assuming we wanted
Internals::ConnectToService() since this class exposes it already and that is
what the test had been using. Which do you prefer?

IMHO embedder.dart is the better approach.  That way we're not replicating the
mojom API in a script API.  We just give the author the underlying Mojo handle
and the author can wrap it in whatever interface they choose.

[sky, 2015-02-23 23:08:25]

On 2015/02/23 22:43:20, abarth wrote:
> On 2015/02/23 at 22:38:57, sky wrote:
> > That can certainly be done. I was assuming we wanted
> Internals::ConnectToService() since this class exposes it already and that is
> what the test had been using. Which do you prefer?
> 
> IMHO embedder.dart is the better approach.  That way we're not replicating the
> mojom API in a script API.  We just give the author the underlying Mojo handle
> and the author can wrap it in whatever interface they choose.

Done. New patch uploaded.

[abarth-chromium, 2015-02-23 23:15:31]

lgtm

[sky, 2015-02-23 23:29:29]

Committed patchset #2 (id:20001) manually as
761cc174d0e2c962ea16267fb76ef90627ee5332 (presubmit successful).