Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
948703002:
[gcc] Fix compiler warning turned into errors while compiling default_header_painter_unittest (Closed)
|
Created:
5 years, 10 months ago by vivekg_samsung Modified:
5 years, 10 months ago CC:
chromium-reviews, kalyank, sadrul Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[gcc] Fix compiler warning turned into errors while compiling default_header_painter_unittest
With gcc toolchain, we get following error with EXPECT_FALSE
error: converting ‘false’ to pointer type for argument 1 of
‘char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)’ [-Werror=conversion-null]
Changing EXPECT_EQ(...) to EXPECT_FALSE() fixes the error.
NOTRY=true
Adding NOTRY as linux_chormium_clobber_rel_ng bot is failing even without the patch.
R=jamescook@chromium.org, benwells@chromium.org
Committed: https://crrev.com/3e9eda0d59c8fd4bd2545aba92481ae5d563c81b
Cr-Commit-Position: refs/heads/master@{#317772}
Patch Set 1 #
Total comments: 1
Patch Set 2 : patch for landing #Messages
Total messages: 27 (12 generated)
vivekg@chromium.org changed reviewers: + vivekg@chromium.org
PTAL thanks.
LGTM with cleanup suggestion https://codereview.chromium.org/948703002/diff/1/ash/frame/default_header_pai... File ash/frame/default_header_painter_unittest.cc (right): https://codereview.chromium.org/948703002/diff/1/ash/frame/default_header_pai... ash/frame/default_header_painter_unittest.cc:77: EXPECT_EQ(true, painter.ShouldUseLightImages()); I would also fix these to be EXPECT_TRUE()
On 2015/02/23 18:10:36, James Cook wrote: > LGTM with cleanup suggestion Thank you. > > https://codereview.chromium.org/948703002/diff/1/ash/frame/default_header_pai... > File ash/frame/default_header_painter_unittest.cc (right): > > https://codereview.chromium.org/948703002/diff/1/ash/frame/default_header_pai... > ash/frame/default_header_painter_unittest.cc:77: EXPECT_EQ(true, > painter.ShouldUseLightImages()); > I would also fix these to be EXPECT_TRUE() Done, PTAL.
Still LGTM
The CQ bit was checked by vivekg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948703002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vivekg@chromium.org
The CQ bit was unchecked by vivekg@chromium.org
The CQ bit was checked by vivekg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948703002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vivekg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948703002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vivekg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948703002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vivekg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948703002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3e9eda0d59c8fd4bd2545aba92481ae5d563c81b Cr-Commit-Position: refs/heads/master@{#317772} |
