Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: ash/frame/default_header_painter_unittest.cc

Issue 948703002: [gcc] Fix compiler warning turned into errors while compiling default_header_painter_unittest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch for landing Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/frame/default_header_painter_unittest.cc
diff --git a/ash/frame/default_header_painter_unittest.cc b/ash/frame/default_header_painter_unittest.cc
index 0bf03ebc88af174b66b8416eb75402738faca9b0..69225b068325be19e357b05053883ae95a36c2f2 100644
--- a/ash/frame/default_header_painter_unittest.cc
+++ b/ash/frame/default_header_painter_unittest.cc
@@ -67,31 +67,31 @@ TEST_F(DefaultHeaderPainterTest, LightIcons) {
// Check by default light icons are not used.
painter.mode_ = HeaderPainter::MODE_ACTIVE;
- EXPECT_EQ(false, painter.ShouldUseLightImages());
+ EXPECT_FALSE(painter.ShouldUseLightImages());
painter.mode_ = HeaderPainter::MODE_INACTIVE;
- EXPECT_EQ(false, painter.ShouldUseLightImages());
+ EXPECT_FALSE(painter.ShouldUseLightImages());
// Check that setting dark colors should use light icons.
painter.SetFrameColors(SkColorSetRGB(0, 0, 0), SkColorSetRGB(0, 0, 0));
painter.mode_ = HeaderPainter::MODE_ACTIVE;
- EXPECT_EQ(true, painter.ShouldUseLightImages());
+ EXPECT_TRUE(painter.ShouldUseLightImages());
painter.mode_ = HeaderPainter::MODE_INACTIVE;
- EXPECT_EQ(true, painter.ShouldUseLightImages());
+ EXPECT_TRUE(painter.ShouldUseLightImages());
// Check that inactive and active colors are used properly.
painter.SetFrameColors(SkColorSetRGB(0, 0, 0), SkColorSetRGB(255, 255, 255));
painter.mode_ = HeaderPainter::MODE_ACTIVE;
- EXPECT_EQ(true, painter.ShouldUseLightImages());
+ EXPECT_TRUE(painter.ShouldUseLightImages());
painter.mode_ = HeaderPainter::MODE_INACTIVE;
- EXPECT_EQ(false, painter.ShouldUseLightImages());
+ EXPECT_FALSE(painter.ShouldUseLightImages());
// Check not so light or dark colors.
painter.SetFrameColors(SkColorSetRGB(70, 70, 70),
SkColorSetRGB(200, 200, 200));
painter.mode_ = HeaderPainter::MODE_ACTIVE;
- EXPECT_EQ(true, painter.ShouldUseLightImages());
+ EXPECT_TRUE(painter.ShouldUseLightImages());
painter.mode_ = HeaderPainter::MODE_INACTIVE;
- EXPECT_EQ(false, painter.ShouldUseLightImages());
+ EXPECT_FALSE(painter.ShouldUseLightImages());
}
} // namespace ash
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698