components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java - Issue 948503004: [Cronet] Enable chunked upload in CronetUrlRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java

Issue 948503004: [Cronet] Enable chunked upload in CronetUrlRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix final chunk in TestDataProvider Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_upload_data_stream_delegate.cc ('k') | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java

diff --git a/components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java b/components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java

index 731623da46284f88e37269429dd7d9901ca82ee1..0427c40d9b683e7da4e448a601ac1901ef3ca809 100644

--- a/components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java

+++ b/components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java

@@ -71,11 +71,6 @@ final class CronetUploadDataStream implements UploadDataSink {

mExecutor = executor;

mDataProvider = dataProvider;

mLength = mDataProvider.getLength();

- if (mLength < 0) {

- // TODO(mmenke): Add tests and remove this line.

- throw new IllegalArgumentException(

- "Chunked uploads not supported.");

- }

}

/**