[Cronet] Enable chunked upload in CronetUrlRequest

components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java

Index: components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java b/components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java
index 7175fbe2ce7a259e97f0be3c4a4efe2e8f3ccd2b..7d4de7f78355cb6e6a1ea02a2c8434647d98c004 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java
@@ -119,7 +119,9 @@ class TestUploadDataProvider implements UploadDataProvider {
         mReadPending = true;
         mStarted = true;
 
-        final boolean finalChunk = (mChunked && mNextRead == mReads.size());
+        final boolean finalChunk =
+                (mChunked && ((mNextRead == mReads.size() - 1 && mReads.get(mNextRead).length == 0)
+                                     || mNextRead == mReads.size()));

[mmenke, 2015/02/26 22:30:19]

This should actually just be:

final boolean finalChunk = (mChunked && mNextRead == mReads.size() - 1);

And further down, the "else if (!finalChunk)" should just be "else".

The original code always appended an empty final chunk to the end, when it
should have just set finalChunk to true for the last element in mReads.  Think
the original API had a special call to indicate a chunked upload was sent, but
then I changed that (Or I was considering that?).  Anyways, that and your two
tests mean we test both cases.  You'll have to update the number of expected
reads in one of them.

[xunjieli, 2015/02/26 22:53:53]

I see. That totally makes sense. Was a little confused about the extra call.
Done.

         if (mNextRead < mReads.size()) {
             if ((byteBuffer.limit() - byteBuffer.position())
                     < mReads.get(mNextRead).length) {