components/cronet/android/cronet_upload_data_stream_adapter.cc - Issue 948503004: [Cronet] Enable chunked upload in CronetUrlRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_upload_data_stream_adapter.cc

Issue 948503004: [Cronet] Enable chunked upload in CronetUrlRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix final chunk in TestDataProvider Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/android/cronet_upload_data_stream_adapter.cc

diff --git a/components/cronet/android/cronet_upload_data_stream_adapter.cc b/components/cronet/android/cronet_upload_data_stream_adapter.cc

index 05ca1ce42ad5c4ba6b840fe3ba79bea4d19c4aff..4ac38b9467237da8e3227a7e909ddd2d8fb5ff35 100644

--- a/components/cronet/android/cronet_upload_data_stream_adapter.cc

+++ b/components/cronet/android/cronet_upload_data_stream_adapter.cc

@@ -87,7 +87,9 @@ void CronetUploadDataStreamAdapter::OnReadSuccess(int bytes_read,

DCHECK(read_in_progress_);

DCHECK(!rewind_in_progress_);

DCHECK(bytes_read > 0 || (final_chunk && bytes_read == 0));

- DCHECK(!is_chunked() || !final_chunk);

+ if (!is_chunked()) {

+ DCHECK(!final_chunk);

+ }

read_in_progress_ = false;