components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java - Issue 948503004: [Cronet] Enable chunked upload in CronetUrlRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java

Issue 948503004: [Cronet] Enable chunked upload in CronetUrlRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java b/components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java

index 7175fbe2ce7a259e97f0be3c4a4efe2e8f3ccd2b..ecc1d656dff1911cb49ddfcd0262cc3321f0171b 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java

@@ -119,7 +119,7 @@ class TestUploadDataProvider implements UploadDataProvider {

mReadPending = true;

mStarted = true;

- final boolean finalChunk = (mChunked && mNextRead == mReads.size());

+ final boolean finalChunk = (mChunked && mNextRead == mReads.size() - 1);

if (mNextRead < mReads.size()) {

if ((byteBuffer.limit() - byteBuffer.position())

< mReads.get(mNextRead).length) {

@@ -128,7 +128,7 @@ class TestUploadDataProvider implements UploadDataProvider {

}

byteBuffer.put(mReads.get(mNextRead));

++mNextRead;

- } else if (!finalChunk) {

+ } else {

throw new IllegalStateException(

"Too many reads: " + mNextRead);

}