Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

Issue 948503004: [Cronet] Enable chunked upload in CronetUrlRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
index d3f93ee7c1bbc686fa5a594e857dbc98e416e199..15f0d92b46f72c5d56c61090f603ced31fde1be6 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
@@ -810,20 +810,53 @@ public class CronetUrlRequestTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
- public void testUploadChunkedNotSupported() throws Exception {
+ public void testUploadChunked() throws Exception {
TestUrlRequestListener listener = new TestUrlRequestListener();
UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
- NativeTestServer.getRedirectToEchoBody(), listener, listener.getExecutor());
+ NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
TestUploadDataProvider dataProvider = new TestUploadDataProvider(
TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
+ dataProvider.addRead("test hello".getBytes());
dataProvider.setChunked(true);
- try {
- urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
- fail("Exception not thrown");
- } catch (IllegalArgumentException e) {
- assertEquals("Chunked uploads not supported.", e.getMessage());
- }
+ urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
+ urlRequest.addHeader("Content-Type", "useless/string");
+
+ assertEquals(-1, dataProvider.getLength());
+
+ urlRequest.start();
+ listener.blockForDone();
+
+ // 1 read call for one data chunk.
+ assertEquals(1, dataProvider.getNumReadCalls());
+ assertEquals("test hello", listener.mResponseAsString);
+ }
+
+ @SmallTest
+ @Feature({"Cronet"})
+ public void testUploadChunkedLastReadZeroLengthBody() throws Exception {
+ TestUrlRequestListener listener = new TestUrlRequestListener();
+ UrlRequest urlRequest = mActivity.mUrlRequestContext.createRequest(
+ NativeTestServer.getEchoBodyURL(), listener, listener.getExecutor());
+
+ TestUploadDataProvider dataProvider = new TestUploadDataProvider(
+ TestUploadDataProvider.SuccessCallbackMode.SYNC, listener.getExecutor());
+ // Add 3 reads. The last read has a 0-length body.
+ dataProvider.addRead("hello there".getBytes());
+ dataProvider.addRead("!".getBytes());
+ dataProvider.addRead("".getBytes());
+ dataProvider.setChunked(true);
+ urlRequest.setUploadDataProvider(dataProvider, listener.getExecutor());
+ urlRequest.addHeader("Content-Type", "useless/string");
+
+ assertEquals(-1, dataProvider.getLength());
+
+ urlRequest.start();
+ listener.blockForDone();
+
+ // 2 read call for the first two data chunks, and 1 for final chunk.
+ assertEquals(3, dataProvider.getNumReadCalls());
+ assertEquals("hello there!", listener.mResponseAsString);
}
private void throwOrCancel(FailureType failureType, ResponseStep failureStep,

Powered by Google App Engine
This is Rietveld 408576698