Fix the binding of the checked and disabled properties of cr-checkbox.

Fix the binding of the checked and disabled properties of cr-checkbox.

Boolean binding is strange and in this case, we didn't actually want question marks in the bindings for the paper-checkbox's attributes. This makes everything work properly.

R=michaelpg
BUG=

Committed: https://crrev.com/c021bb36c0e11541be2bf9c5ab5c9bce0dd5d6c3
Cr-Commit-Position: refs/heads/master@{#318132}

[Kyle Horimoto, 2015-02-25 18:51:08]

khorimoto@chromium.org changed reviewers:
+ khorimoto@chromium.org

[Kyle Horimoto, 2015-02-25 18:51:19]

lgtm

https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
File ui/webui/resources/cr_elements/cr_toggle_button/cr_toggle_button.html
(right):

https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
ui/webui/resources/cr_elements/cr_toggle_button/cr_toggle_button.html:11:
checked="{{ checked }}" disabled="{{ disabled }}">
nit: Let's get rid of the extra whitespace in the {{ }} as well.

[michaelpg, 2015-02-25 19:03:36]

https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
File ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html (left):

https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html:11:
checked?="{{checked}}" disabled?="{{disabled}}" label="{{label}}">
Hmm, this seems to work for me. What are you seeing?

[Kyle Horimoto, 2015-02-25 19:11:51]

On 2015/02/25 19:03:36, michaelpg wrote:
>
https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
> File ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html (left):
> 
>
https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
> ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html:11:
> checked?="{{checked}}" disabled?="{{disabled}}" label="{{label}}">
> Hmm, this seems to work for me. What are you seeing?

The binding is only working one way. `crCheckbox.checked = true;` results in
paperCheckbox.checked being set, but clicking the checkbox results in only the
paperCheckbox.checked property changing, not the crCheckbox.checked property
changing.

[Jeremy Klein, 2015-02-25 19:22:11]

On 2015/02/25 19:11:51, Kyle Horimoto wrote:
> On 2015/02/25 19:03:36, michaelpg wrote:
> >
>
https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
> > File ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html (left):
> > 
> >
>
https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
> > ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html:11:
> > checked?="{{checked}}" disabled?="{{disabled}}" label="{{label}}">
> > Hmm, this seems to work for me. What are you seeing?
> 
> The binding is only working one way. `crCheckbox.checked = true;` results in
> paperCheckbox.checked being set, but clicking the checkbox results in only the
> paperCheckbox.checked property changing, not the crCheckbox.checked property
> changing.

What Kyle said... watch the checked attribute on cr-checkbox rather than on
paper-checkbox and you'll notice it only changes without the question mark.

[michaelpg, 2015-02-25 19:57:43]

On 2015/02/25 19:22:11, Jeremy Klein wrote:
> On 2015/02/25 19:11:51, Kyle Horimoto wrote:
> > On 2015/02/25 19:03:36, michaelpg wrote:
> > >
> >
>
https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
> > > File ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
> > > ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html:11:
> > > checked?="{{checked}}" disabled?="{{disabled}}" label="{{label}}">
> > > Hmm, this seems to work for me. What are you seeing?
> > 
> > The binding is only working one way. `crCheckbox.checked = true;` results in
> > paperCheckbox.checked being set, but clicking the checkbox results in only
the
> > paperCheckbox.checked property changing, not the crCheckbox.checked property
> > changing.
> 
> What Kyle said... watch the checked attribute on cr-checkbox rather than on
> paper-checkbox and you'll notice it only changes without the question mark.

That's... weird. Good catch, lgtm.

[Jeremy Klein, 2015-02-25 20:00:41]

https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
File ui/webui/resources/cr_elements/cr_toggle_button/cr_toggle_button.html
(right):

https://codereview.chromium.org/948283004/diff/2/ui/webui/resources/cr_elemen...
ui/webui/resources/cr_elements/cr_toggle_button/cr_toggle_button.html:11:
checked="{{ checked }}" disabled="{{ disabled }}">
On 2015/02/25 18:51:19, Kyle Horimoto wrote:
> nit: Let's get rid of the extra whitespace in the {{ }} as well.

Done.

[Jeremy Klein, 2015-02-25 20:01:02]

The CQ bit was checked by jlklein@chromium.org

[Jeremy Klein, 2015-02-25 20:01:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
khorimoto@chromium.org, michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/948283004/#ps30001 (title:
"Remove spaces around binding braces.")

[commit-bot: I haz the power, 2015-02-25 20:01:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/948283004/30001

[commit-bot: I haz the power, 2015-02-25 22:47:01]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2015-02-25 22:49:35]

Patchset 3 (id:??) landed as
https://crrev.com/c021bb36c0e11541be2bf9c5ab5c9bce0dd5d6c3
Cr-Commit-Position: refs/heads/master@{#318132}