ui/webui/resources/cr_elements/cr_toggle_button/cr_toggle_button.html - Issue 948283004: Fix the binding of the checked and disabled properties of cr-checkbox.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/cr_elements/cr_toggle_button/cr_toggle_button.html

Issue 948283004: Fix the binding of the checked and disabled properties of cr-checkbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix the toggle button. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <link rel="import"	1 <link rel="import"

2 href="chrome://resources/polymer/paper-toggle-button/paper-toggle-button.htm l">	2 href="chrome://resources/polymer/paper-toggle-button/paper-toggle-button.htm l">

3 <link rel="import"	3 <link rel="import"

4 href="chrome://resources/cr_elements/cr_events/cr_events.html">	4 href="chrome://resources/cr_elements/cr_events/cr_events.html">

5	5

6 <polymer-element name="cr-toggle-button">	6 <polymer-element name="cr-toggle-button">

7 <template>	7 <template>

8 <link rel="stylesheet" href="cr_toggle_button.css">	8 <link rel="stylesheet" href="cr_toggle_button.css">

9 <cr-events id="events"></cr-events>	9 <cr-events id="events"></cr-events>

10 <paper-toggle-button id="button"	10 <paper-toggle-button id="button"

11 checked?="{{ checked }}" disabled?="{{ disabled }}">	11 checked="{{ checked }}" disabled="{{ disabled }}">
	Kyle Horimoto 2015/02/25 18:51:19 nit: Let's get rid of the extra whitespace in the nit: Let's get rid of the extra whitespace in the {{ }} as well. Jeremy Klein 2015/02/25 20:00:41 Done. Show quoted text On 2015/02/25 18:51:19, Kyle Horimoto wrote: > nit: Let's get rid of the extra whitespace in the {{ }} as well. Done.
12 </paper-toggle-button>	12 </paper-toggle-button>

13 </template>	13 </template>

14 <script src="cr_toggle_button.js"></script>	14 <script src="cr_toggle_button.js"></script>

15 </polymer-element>	15 </polymer-element>

OLD	NEW

« ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html ('K') | « ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html ('k') | no next file » | no next file with comments »