cc: Misc animation refactoring

cc/trees/layer_tree_impl.h

Index: cc/trees/layer_tree_impl.h
diff --git a/cc/trees/layer_tree_impl.h b/cc/trees/layer_tree_impl.h
index 5935d29e77cac830e0d1d8269922be242ab4343d..60acaf51a4ab34a4c662955db2ee587ad61138d5 100644
--- a/cc/trees/layer_tree_impl.h
+++ b/cc/trees/layer_tree_impl.h
@@ -239,7 +239,7 @@ class CC_EXPORT LayerTreeImpl {
 
   size_t NumLayers();
 
-  AnimationRegistrar* animationRegistrar() const;
+  AnimationRegistrar* animation_registrar() const;

[sunnyps, 2015/02/24 06:22:25]

I know this method is not inlined and is yet using snake_case. The google style
guide is vague about this, it says "simple" method can be named in snake_case.
However the main reason for doing this is that C++ hates using the same function
name as the class (it fails to compile on certain bots). Between this and the
other option (animationRegistrar), I chose this because other methods in the
class are named in a similar way.

[danakj, 2015/02/24 07:21:17]

I think what you want is GetAnimationRegistrar(). We dont use Get enough in cc
(due to WebKit history I think).  Verbs are good. 

[sunnyps, 2015/02/24 20:13:37]

Done.

 
   void PushPersistedState(LayerTreeImpl* pending_tree);