cc: Misc animation refactoring

cc/trees/layer_tree_impl.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TREES_LAYER_TREE_IMPL_H_
 #define CC_TREES_LAYER_TREE_IMPL_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 221 matching lines @@
   gfx::Rect RootScrollLayerDeviceViewportBounds() const;
 
   LayerImpl* LayerById(int id);
 
   // These should be called by LayerImpl's ctor/dtor.
   void RegisterLayer(LayerImpl* layer);
   void UnregisterLayer(LayerImpl* layer);
 
   size_t NumLayers();
 
-  AnimationRegistrar* animationRegistrar() const;
+  AnimationRegistrar* animation_registrar() const;

[sunnyps, 2015/02/24 06:22:25]

I know this method is not inlined and is yet using snake_case. The google style
guide is vague about this, it says "simple" method can be named in snake_case.
However the main reason for doing this is that C++ hates using the same function
name as the class (it fails to compile on certain bots). Between this and the
other option (animationRegistrar), I chose this because other methods in the
class are named in a similar way.

[danakj, 2015/02/24 07:21:17]

I think what you want is GetAnimationRegistrar(). We dont use Get enough in cc
(due to WebKit history I think).  Verbs are good. 

[sunnyps, 2015/02/24 20:13:37]

Done.

 
   void PushPersistedState(LayerTreeImpl* pending_tree);
 
   void DidBecomeActive();
 
   bool ContentsTexturesPurged() const;
   void SetContentsTexturesPurged();
   void ResetContentsTexturesPurged();
 
   // Set on the active tree when the viewport size recently changed
@@ skipping 165 matching lines @@
 
   scoped_ptr<PendingPageScaleAnimation> pending_page_scale_animation_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(LayerTreeImpl);
 };
 
 }  // namespace cc
 
 #endif  // CC_TREES_LAYER_TREE_IMPL_H_