Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 948233002: Fix GN build after PNG support backport (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix GN build after PNG support backport Follow-on from https://codereview.chromium.org/950113002. This would block a pdfium roll until corrected. TBR=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0fd53cf2578c4c2ba20fdcb6017eee51f26c7cba

Patch Set 1 #

Patch Set 2 : Add to samples group. #

Patch Set 3 : Fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M samples/BUILD.gn View 1 2 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tom Sepez
5 years, 10 months ago (2015-02-24 01:36:53 UTC) #1
Tom Sepez
5 years, 10 months ago (2015-02-24 01:56:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
0fd53cf2578c4c2ba20fdcb6017eee51f26c7cba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698