Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 948203002: Change autofill credit card suggestion text on Android. (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change autofill credit card suggestion text on Android. This applies when initiating a credit card form fill from a field other than credit card number (e.g. cardholder name). BUG=none Committed: https://crrev.com/d7d7aa265d725abad14c4385f8e4a9c88d170845 Cr-Commit-Position: refs/heads/master@{#318312}

Patch Set 1 #

Patch Set 2 : compile more #

Patch Set 3 : compile? #

Patch Set 4 : fix android tests? (trouble testing locally :() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 2 3 2 chunks +7 lines, -3 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 2 3 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Evan Stade
5 years, 10 months ago (2015-02-24 18:25:24 UTC) #2
please use gerrit instead
lgtm
5 years, 10 months ago (2015-02-24 18:29:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948203002/20001
5 years, 10 months ago (2015-02-24 18:40:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/50648)
5 years, 10 months ago (2015-02-24 20:35:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948203002/40001
5 years, 10 months ago (2015-02-24 23:04:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/14237) ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-24 23:20:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948203002/40001
5 years, 10 months ago (2015-02-25 22:58:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/6009)
5 years, 10 months ago (2015-02-26 02:24:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948203002/60001
5 years, 10 months ago (2015-02-26 20:22:31 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-26 21:17:43 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 21:19:02 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/d7d7aa265d725abad14c4385f8e4a9c88d170845
Cr-Commit-Position: refs/heads/master@{#318312}

Powered by Google App Engine
This is Rietveld 408576698