Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: components/autofill/core/browser/autofill_manager_unittest.cc

Issue 948203002: Change autofill credit card suggestion text on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android tests? (trouble testing locally :() Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/personal_data_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_manager_unittest.cc
diff --git a/components/autofill/core/browser/autofill_manager_unittest.cc b/components/autofill/core/browser/autofill_manager_unittest.cc
index def37313dd23bb8aeaecf0d05f3b4653f4e8a16c..144925ae9bd9e6dad64bb559c1ee8aee259e8cb8 100644
--- a/components/autofill/core/browser/autofill_manager_unittest.cc
+++ b/components/autofill/core/browser/autofill_manager_unittest.cc
@@ -913,12 +913,20 @@ TEST_F(AutofillManagerTest, GetCreditCardSuggestionsNonCCNumber) {
// This triggers the combined message send.
AutocompleteSuggestionsReturned(std::vector<base::string16>());
+#if defined(OS_ANDROID)
+ static const char* kVisaSuggestion = "Visa - 3456";
+ static const char* kMcSuggestion = "MasterCard - 8765";
+#else
+ static const char* kVisaSuggestion = "*3456";
+ static const char* kMcSuggestion = "*8765";
+#endif
+
// Test that we sent the right values to the external delegate.
external_delegate_->CheckSuggestions(
kDefaultPageID,
- Suggestion("Elvis Presley", "*3456", kVisaCard,
+ Suggestion("Elvis Presley", kVisaSuggestion, kVisaCard,
autofill_manager_->GetPackedCreditCardID(4)),
- Suggestion("Buddy Holly", "*8765", kMasterCard,
+ Suggestion("Buddy Holly", kMcSuggestion, kMasterCard,
autofill_manager_->GetPackedCreditCardID(5)));
}
« no previous file with comments | « no previous file | components/autofill/core/browser/personal_data_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698