Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 948193003: Roll libvpx 33bbff:6a19aa (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
Reviewers:
Johann
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll libvpx 33bbff:6a19aa Update the libvpx GN build files with the cpu_arch -> current_cpu change: https://codereview.chromium.org/942153003 TBR=johannkoenig@google.com BUG=344767 Committed: https://crrev.com/b79e3657ab4c968ffb5eae952ff7f3b48831e632 Cr-Commit-Position: refs/heads/master@{#317741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Dirk Pranke
5 years, 10 months ago (2015-02-23 23:48:14 UTC) #1
Johann
LGTM - but beware that I'm not a full committer so the commit process might ...
5 years, 10 months ago (2015-02-23 23:52:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948193003/1
5 years, 10 months ago (2015-02-23 23:52:23 UTC) #4
Dirk Pranke
On 2015/02/23 23:52:20, Johann wrote: > LGTM - but beware that I'm not a full ...
5 years, 10 months ago (2015-02-24 00:01:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 02:10:53 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b79e3657ab4c968ffb5eae952ff7f3b48831e632 Cr-Commit-Position: refs/heads/master@{#317741}
5 years, 10 months ago (2015-02-24 02:12:06 UTC) #7
Johann
5 years, 10 months ago (2015-02-24 16:05:28 UTC) #8
Message was sent while issue was closed.
On 2015/02/24 00:01:00, Dirk Pranke wrote:
> On 2015/02/23 23:52:20, Johann wrote:
> > LGTM - but beware that I'm not a full committer so the commit process might
> > complain.
> 
> Since I'm a full committer and the review is TBR= , it doesn't really need a
> reviewer, so you approving it is already above and beyond :).

Excellent :)

Powered by Google App Engine
This is Rietveld 408576698