Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1273)

Issue 942153003: Update the libvpx GN build files with the cpu_arch -> current_cpu change. (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
Reviewers:
Johann, Tom Finegan
CC:
wwcv, jzern, fgalligan1, Tom Finegan
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update the libvpx GN build files with the cpu_arch -> current_cpu change. This updates the build to remove references to the newly deprecated variables. R=johannkoenig@google.com, tomfinegan@chromium.org BUG=344767 Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/6a19aa1e1f636f40eda73a1378586e0b514fb9cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M BUILD.gn View 13 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Dirk Pranke
Hi Tom, Can you take a look at this and, assuming it looks okay to ...
5 years, 10 months ago (2015-02-20 20:26:38 UTC) #1
Johann
LGTM should the bug be just the number, instead of the full url? To roll, ...
5 years, 10 months ago (2015-02-20 21:30:39 UTC) #3
Dirk Pranke
On 2015/02/20 21:30:39, Johann wrote: > should the bug be just the number, instead of ...
5 years, 10 months ago (2015-02-20 21:51:03 UTC) #4
Johann
On 2015/02/20 21:51:03, Dirk Pranke wrote: > On 2015/02/20 21:30:39, Johann wrote: > > should ...
5 years, 10 months ago (2015-02-20 21:53:25 UTC) #6
Dirk Pranke
How would one get this patch committed? I don't know that I'm a committer on ...
5 years, 10 months ago (2015-02-20 21:55:55 UTC) #8
Johann
On 2015/02/20 21:55:55, Dirk Pranke wrote: > How would one get this patch committed? I ...
5 years, 10 months ago (2015-02-20 21:57:10 UTC) #9
Johann
On 2015/02/20 21:57:10, Johann wrote: > On 2015/02/20 21:55:55, Dirk Pranke wrote: > > How ...
5 years, 10 months ago (2015-02-20 21:58:16 UTC) #10
Dirk Pranke
Committed patchset #1 (id:1) manually as 6a19aa1e1f636f40eda73a1378586e0b514fb9cd (presubmit successful).
5 years, 10 months ago (2015-02-20 21:59:46 UTC) #11
Dirk Pranke
5 years, 10 months ago (2015-02-20 22:00:31 UTC) #12
Message was sent while issue was closed.
On 2015/02/20 21:58:16, Johann wrote:
> On 2015/02/20 21:57:10, Johann wrote:
> > On 2015/02/20 21:55:55, Dirk Pranke wrote:
> > > How would one get this patch committed? I don't know that I'm a committer
on
> > > this repo, nor whether I need to run try jobs (I don't think there's a CQ
> ...)
> > 
> > Ahh, sorry:
> > git cl land
> 
> As long as you're a chromium committer it will work. If you're only partial
like
> me, you need an LGTM from a real one (like Tom). The repo is more owned by
> chromium than by webm.

Got it, thanks!

Powered by Google App Engine
This is Rietveld 408576698