Issue 948083002: Merge to XFA: Replace second set of #defines with templates in JS_Define.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 948083002: Merge to XFA: Replace second set of #defines with templates in JS_Define.h (Closed)

Created:
5 years, 10 months ago by Tom Sepez

Modified:
5 years, 10 months ago

Reviewers:
brucedawson

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -141 lines)			Patch
	M	fpdfsdk/include/javascript/JS_Define.h	View		3 chunks	+94 lines, -121 lines	0 comments	Download
	M	fpdfsdk/include/jsapi/fxjs_v8.h	View		4 chunks	+6 lines, -20 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as 2311b784fe85a0a1d78f78f0f05586059a63fa65 (presubmit successful).

5 years, 10 months ago (2015-02-23 18:22:56 UTC) #2

Message was sent while issue was closed.

lgtm