Replace second set of #defines with templates in JS_Define.h

Replace second set of #defines with templates in JS_Define.h

Continuation of effort now that a test case is present on origin/master.

R=brucedawson@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/28ddd48bfd84c55cc51d0b16fa533c51affdeb5b

[Tom Sepez, 2015-02-20 00:19:12]

tsepez@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Tom Sepez, 2015-02-20 00:19:12]

Bruce, more fun. Thanks.

[brucedawson, 2015-02-20 23:52:40]

lgtm

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
File fpdfsdk/include/javascript/JS_Define.h (left):

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
fpdfsdk/include/javascript/JS_Define.h:355: JS_Error(NULL,L"GetProperty",
L"Embeded object not found!");\
Well that's a weird line of code...

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
File fpdfsdk/include/javascript/JS_Define.h (right):

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
fpdfsdk/include/javascript/JS_Define.h:46: typedef CFX_ArrayTemplate<int>
CJS_IntArray;
Why was this ever a #define? Sigh...

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
fpdfsdk/include/javascript/JS_Define.h:300: IFXJS_Context* cc =
pRuntime->GetCurrentContext();
Consider naming this pRuntimeContext or something like that? cc is rather short
and cryptic.

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
fpdfsdk/include/javascript/JS_Define.h:327: IFXJS_Context* cc =
pRuntime->GetCurrentContext();
Consider naming this pRuntimeContext or something like that? cc is rather short
and cryptic.

[Tom Sepez, 2015-02-23 17:58:13]

New patchsets have been uploaded after l-g-t-m from brucedawson@chromium.org

[Tom Sepez, 2015-02-23 17:58:30]

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
File fpdfsdk/include/javascript/JS_Define.h (left):

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
fpdfsdk/include/javascript/JS_Define.h:355: JS_Error(NULL,L"GetProperty",
L"Embeded object not found!");\
On 2015/02/20 23:52:40, brucedawson wrote:
> Well that's a weird line of code...
If by weird, you mean unreachable, given returns in both branches of the
if-statement above, then yes.

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
File fpdfsdk/include/javascript/JS_Define.h (right):

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
fpdfsdk/include/javascript/JS_Define.h:300: IFXJS_Context* cc =
pRuntime->GetCurrentContext();
On 2015/02/20 23:52:40, brucedawson wrote:
> Consider naming this pRuntimeContext or something like that? cc is rather
short
> and cryptic.

Done.

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
fpdfsdk/include/javascript/JS_Define.h:327: IFXJS_Context* cc =
pRuntime->GetCurrentContext();
On 2015/02/20 23:52:40, brucedawson wrote:
> Consider naming this pRuntimeContext or something like that? cc is rather
short
> and cryptic.

Done.

https://codereview.chromium.org/945623002/diff/1/fpdfsdk/include/javascript/J...
fpdfsdk/include/javascript/JS_Define.h:351: IFXJS_Context* cc =
pRuntime->GetCurrentContext();
renamed here too.

[Tom Sepez, 2015-02-23 18:03:18]

Committed patchset #2 (id:20001) manually as
28ddd48bfd84c55cc51d0b16fa533c51affdeb5b (presubmit successful).