Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 948043002: break out of cubic stroker loop on degenerate case (Closed)

Created:
5 years, 10 months ago by caryclark
Modified:
5 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

break out of cubic stroker loop on degenerate case The looper can generate more than one quad, but if any one is degenerate, give up, but not before generating the state for the line join to produce the correct end. Before, the early return allowed the inside path to contain multiple movetos that caused reversePath to assert. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/6df8e3495a677a5df2476d2ff3bbe878fd178e4b

Patch Set 1 #

Total comments: 2

Patch Set 2 : find root cause for dash cubic failure; add more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M gm/dashcubics.cpp View 1 2 chunks +28 lines, -17 lines 0 comments Download
M src/core/SkStroke.cpp View 1 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948043002/1
5 years, 10 months ago (2015-02-23 15:42:29 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-23 15:42:29 UTC) #3
reed1
https://codereview.chromium.org/948043002/diff/1/src/core/SkStroke.cpp File src/core/SkStroke.cpp (right): https://codereview.chromium.org/948043002/diff/1/src/core/SkStroke.cpp#newcode1414 src/core/SkStroke.cpp:1414: if (!this->cubicStroke(cubic, &quadPts)) { Can we add a brief ...
5 years, 10 months ago (2015-02-23 15:44:12 UTC) #4
caryclark
https://codereview.chromium.org/948043002/diff/1/src/core/SkStroke.cpp File src/core/SkStroke.cpp (right): https://codereview.chromium.org/948043002/diff/1/src/core/SkStroke.cpp#newcode1414 src/core/SkStroke.cpp:1414: if (!this->cubicStroke(cubic, &quadPts)) { On 2015/02/23 15:44:12, reed1 wrote: ...
5 years, 10 months ago (2015-02-23 17:10:47 UTC) #5
reed1
lgtm
5 years, 10 months ago (2015-02-23 20:21:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948043002/20001
5 years, 10 months ago (2015-02-23 20:38:18 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 20:47:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6df8e3495a677a5df2476d2ff3bbe878fd178e4b

Powered by Google App Engine
This is Rietveld 408576698