break out of cubic stroker loop on degenerate case

src/core/SkStroke.cpp

 /*
  * Copyright 2008 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkStrokerPriv.h"
 #include "SkGeometry.h"
 #include "SkPath.h"
@@ skipping 1393 matching lines @@
     SkASSERT(kQuad_ReductionType == reductionType);
     SkVector normalAB, unitAB, normalCD, unitCD;
     this->preJoinTo(*tangentPt, &normalAB, &unitAB, false);
     SkScalar tValues[2];
     int count = SkFindCubicInflections(cubic, tValues);
     SkScalar lastT = 0;
     for (int index = 0; index <= count; ++index) {
         SkScalar nextT = index < count ? tValues[index] : 1;
         SkQuadConstruct quadPts;
         this->init(kOuter_StrokeType, &quadPts, lastT, nextT);
         if (!this->cubicStroke(cubic, &quadPts)) {

[reed1, 2015/02/23 15:44:12]

Can we add a brief comment as to why this might occur, and what the resulting
outer/inner will be as a result?

[caryclark, 2015/02/23 17:10:47]

Done.

-            return;
+            break;
         }
         this->init(kInner_StrokeType, &quadPts, lastT, nextT);
         if (!this->cubicStroke(cubic, &quadPts)) {
-            return;
+            break;
         }
         lastT = nextT;
     }
     this->setCubicEndNormal(cubic, normalAB, unitAB, &normalCD, &unitCD);
 #else
     bool    degenerateAB = SkPath::IsLineDegenerate(fPrevPt, pt1);
     bool    degenerateBC = SkPath::IsLineDegenerate(pt1, pt2);
     bool    degenerateCD = SkPath::IsLineDegenerate(pt2, pt3);
 
     if (degenerateAB + degenerateBC + degenerateCD >= 2
@@ skipping 306 matching lines @@
         default:
             break;
     }
 
     if (fWidth < SkMinScalar(rw, rh) && !fDoFill) {
         r = rect;
         r.inset(radius, radius);
         dst->addRect(r, reverse_direction(dir));
     }
 }