Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 948033002: [turbofan] only use two gaps (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] only use two gaps BUG= Committed: https://crrev.com/43c7345b35a6a4eea4bf53eb1a8532ff436b461e Cr-Commit-Position: refs/heads/master@{#26814}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : rebase #

Total comments: 1

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -144 lines) Patch
M src/compiler/instruction.h View 1 2 3 4 5 3 chunks +8 lines, -6 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 3 4 5 6 1 chunk +22 lines, -0 lines 0 comments Download
M src/compiler/move-optimizer.cc View 2 chunks +1 line, -28 lines 0 comments Download
M src/compiler/register-allocator.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 2 chunks +63 lines, -38 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.h View 1 6 chunks +27 lines, -23 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 10 chunks +56 lines, -45 lines 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Benedikt Meurer
LGTM with comment https://codereview.chromium.org/948033002/diff/120001/src/compiler/instruction.cc File src/compiler/instruction.cc (right): https://codereview.chromium.org/948033002/diff/120001/src/compiler/instruction.cc#newcode100 src/compiler/instruction.cc:100: DCHECK(!(replacement == to_eliminate && replacement != ...
5 years, 10 months ago (2015-02-24 10:41:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/948033002/140001
5 years, 10 months ago (2015-02-24 10:46:28 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:140001)
5 years, 10 months ago (2015-02-24 11:09:09 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 11:09:27 UTC) #8
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/43c7345b35a6a4eea4bf53eb1a8532ff436b461e
Cr-Commit-Position: refs/heads/master@{#26814}

Powered by Google App Engine
This is Rietveld 408576698