Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: src/compiler/instruction.h

Issue 948033002: [turbofan] only use two gaps (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/instruction.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction.h
diff --git a/src/compiler/instruction.h b/src/compiler/instruction.h
index e36e8936d67d3fb8b6963ad9b57df3c43a80029d..fe411d612977cb115114c49ac6730738acb9fa14 100644
--- a/src/compiler/instruction.h
+++ b/src/compiler/instruction.h
@@ -400,6 +400,12 @@ class ParallelMove FINAL : public ZoneObject {
return &move_operands_;
}
+ // Prepare this ParallelMove to insert move as if it happened in a subsequent
+ // ParallelMove. move->source() may be changed. The MoveOperand returned
+ // must be Eliminated and, as it points directly into move_operands_, it must
+ // be Eliminated before any further mutation.
+ MoveOperands* PrepareInsertAfter(MoveOperands* move) const;
+
private:
ZoneList<MoveOperands> move_operands_;
};
@@ -596,12 +602,10 @@ std::ostream& operator<<(std::ostream& os, const PrintableInstruction& instr);
class GapInstruction : public Instruction {
public:
enum InnerPosition {
- BEFORE,
START,
END,
- AFTER,
- FIRST_INNER_POSITION = BEFORE,
- LAST_INNER_POSITION = AFTER
+ FIRST_INNER_POSITION = START,
+ LAST_INNER_POSITION = END
};
ParallelMove* GetOrCreateParallelMove(InnerPosition pos, Zone* zone) {
@@ -640,10 +644,8 @@ class GapInstruction : public Instruction {
protected:
explicit GapInstruction(InstructionCode opcode) : Instruction(opcode) {
- parallel_moves_[BEFORE] = NULL;
parallel_moves_[START] = NULL;
parallel_moves_[END] = NULL;
- parallel_moves_[AFTER] = NULL;
}
private:
« no previous file with comments | « no previous file | src/compiler/instruction.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698