cc: Use the Lint function from depot_tools' presubmit_canned_checks API.

cc: Use the Lint function from depot_tools' presubmit_canned_checks API.

BUG=None
TEST=git cl upload && g cl presubmit -uvf
R=danakj@chromium.org

Committed: https://crrev.com/2d64901502372c07aa9faed8e02dcb0b9d35cad8
Cr-Commit-Position: refs/heads/master@{#318224}

[tfarina, 2015-02-24 01:50:24]

https://codereview.chromium.org/947983003/diff/1/cc/PRESUBMIT.py
File cc/PRESUBMIT.py (left):

https://codereview.chromium.org/947983003/diff/1/cc/PRESUBMIT.py#oldcode20
cc/PRESUBMIT.py:20: files = [f.AbsoluteLocalPath() for f in
This code is basically repeating what CheckChangeLintsClean do in
https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/presubm...

But with level 1 rather than 5 or 4.

https://codereview.chromium.org/947983003/diff/1/cc/PRESUBMIT.py
File cc/PRESUBMIT.py (right):

https://codereview.chromium.org/947983003/diff/1/cc/PRESUBMIT.py#newcode21
cc/PRESUBMIT.py:21: return input_api.canned_checks.CheckChangeLintsClean(
Is this OK?

[danakj, 2015-02-24 07:29:52]

Doesnt this change the linting level to be less strict?
On Feb 23, 2015 5:50 PM, <tfarina@chromium.org> wrote:

> Reviewers: danakj,
>
>
> https://codereview.chromium.org/947983003/diff/1/cc/PRESUBMIT.py
> File cc/PRESUBMIT.py (left):
>
> https://codereview.chromium.org/947983003/diff/1/cc/PRESUBMIT.py#oldcode20
> cc/PRESUBMIT.py:20: files = [f.AbsoluteLocalPath() for f in
> This code is basically repeating what CheckChangeLintsClean do in
> https://chromium.googlesource.com/chromium/tools/depot_
> tools/+/master/presubmit_canned_checks.py#114
>
> But with level 1 rather than 5 or 4.
>
> https://codereview.chromium.org/947983003/diff/1/cc/PRESUBMIT.py
> File cc/PRESUBMIT.py (right):
>
> https://codereview.chromium.org/947983003/diff/1/cc/PRESUBMIT.py#newcode21
> cc/PRESUBMIT.py:21: return
> input_api.canned_checks.CheckChangeLintsClean(
> Is this OK?
>
> Description:
> cc: Use the Lint function from depot_tools' presubmit_canned_checks API.
>
> BUG=None
> TEST=git cl upload && g cl presubmit -uvf
> R=danakj@chromium.org
>
> Please review this at https://codereview.chromium.org/947983003/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+2, -11 lines):
>   M cc/PRESUBMIT.py
>
>
> Index: cc/PRESUBMIT.py
> diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py
> index dc826b1218cc0b5f53dd66d8469cb9b918e1dd50..
> ad34d7ceb125d4f02ca5348f5ffb5dd9ba7abb49 100644
> --- a/cc/PRESUBMIT.py
> +++ b/cc/PRESUBMIT.py
> @@ -17,18 +17,9 @@ def CheckChangeLintsClean(input_api, output_api):
>    input_api.cpplint._cpplint_state.ResetErrorCounts()  # reset global
> state
>    source_filter = lambda x: input_api.FilterSourceFile(
>      x, white_list=CC_SOURCE_FILES, black_list=None)
> -  files = [f.AbsoluteLocalPath() for f in
> -           input_api.AffectedSourceFiles(source_filter)]
> -  level = 1  # strict, but just warn
>
> -  for file_name in files:
> -    input_api.cpplint.ProcessFile(file_name, level)
> -
> -  if not input_api.cpplint._cpplint_state.error_count:
> -    return []
> -
> -  return [output_api.PresubmitPromptWarning(
> -    'Changelist failed cpplint.py check.')]
> +  return input_api.canned_checks.CheckChangeLintsClean(
> +      input_api, output_api, source_filter, [])
>
>  def CheckAsserts(input_api, output_api, white_list=CC_SOURCE_FILES,
> black_list=None):
>    black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST)
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-02-24 15:57:02]

Yeah, looks like this change the verbosity level from 1 to 4 or 5 depending if
it is a normal file or a unit test file.

https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/presubm...

I will look into passing verbose_level down to presubmit_canned_checks.py.

Does that sound good?

[danakj, 2015-02-24 17:14:03]

On Tue, Feb 24, 2015 at 7:57 AM, <tfarina@chromium.org> wrote:

> Yeah, looks like this change the verbosity level from 1 to 4 or 5
> depending if
> it is a normal file or a unit test file.
>
> https://chromium.googlesource.com/chromium/tools/depot_
> tools/+/master/presubmit_canned_checks.py#114
>
> I will look into passing verbose_level down to presubmit_canned_checks.py.
>
> Does that sound good?
>

If you like, I'm not convinced it's worth the effort but up to you. Or we
could work on getting all chromium code to pass at 1 then we can just
change it to that.


>
> https://codereview.chromium.org/947983003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-02-25 17:17:31]

Dana, it is ready for another look.

[danakj, 2015-02-25 18:47:23]

LGTM

[tfarina, 2015-02-26 12:49:05]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-02-26 12:49:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947983003/40001

[commit-bot: I haz the power, 2015-02-26 12:58:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-26 12:59:05]

Patchset 3 (id:??) landed as
https://crrev.com/2d64901502372c07aa9faed8e02dcb0b9d35cad8
Cr-Commit-Position: refs/heads/master@{#318224}