cc: Use the Lint function from depot_tools' presubmit_canned_checks API.

cc/PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for cc.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
 import re
 import string
 
 CC_SOURCE_FILES=(r'^cc[\\/].*\.(cc|h)$',)
 
 def CheckChangeLintsClean(input_api, output_api):
   input_api.cpplint._cpplint_state.ResetErrorCounts()  # reset global state
   source_filter = lambda x: input_api.FilterSourceFile(
     x, white_list=CC_SOURCE_FILES, black_list=None)
-  files = [f.AbsoluteLocalPath() for f in

[tfarina, 2015/02/24 01:50:23]

This code is basically repeating what CheckChangeLintsClean do in
https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/presubm...

But with level 1 rather than 5 or 4.

-           input_api.AffectedSourceFiles(source_filter)]
-  level = 1  # strict, but just warn
 
-  for file_name in files:
-    input_api.cpplint.ProcessFile(file_name, level)
-
-  if not input_api.cpplint._cpplint_state.error_count:
-    return []
-
-  return [output_api.PresubmitPromptWarning(
-    'Changelist failed cpplint.py check.')]
+  return input_api.canned_checks.CheckChangeLintsClean(

[tfarina, 2015/02/24 01:50:24]

Is this OK?

+      input_api, output_api, source_filter, [])
 
 def CheckAsserts(input_api, output_api, white_list=CC_SOURCE_FILES, black_list=None):
   black_list = tuple(black_list or input_api.DEFAULT_BLACK_LIST)
   source_file_filter = lambda x: input_api.FilterSourceFile(x, white_list, black_list)
 
   assert_files = []
   notreached_files = []
 
   for f in input_api.AffectedSourceFiles(source_file_filter):
     contents = input_api.ReadFile(f, 'rb')
@@ skipping 294 matching lines @@
   results += FindUselessIfdefs(input_api, output_api)
   results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
   return results
 
 def GetPreferredTryMasters(project, change):
   return {
     'tryserver.blink': {
       'linux_blink_rel': set(['defaulttests']),
     },
   }