Source/core/layout/LayoutInline.cpp - Issue 947793002: Reland "We need to account for culled inline parents of hit-tested nodes"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutInline.cpp

Issue 947793002: Reland "We need to account for culled inline parents of hit-tested nodes" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutInline.cpp

diff --git a/Source/core/layout/LayoutInline.cpp b/Source/core/layout/LayoutInline.cpp

index e537fc00f9cf949f468bb5ad426e37eeaf8e216f..aa6914d9a693628738913567bd32a7357525f703 100644

--- a/Source/core/layout/LayoutInline.cpp

+++ b/Source/core/layout/LayoutInline.cpp

@@ -812,7 +812,7 @@ private:

bool LayoutInline::hitTestCulledInline(HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset)

{

- ASSERT(result.isRectBasedTest() && !alwaysCreateLineBoxes());

+ ASSERT(!alwaysCreateLineBoxes());

if (!visibleToHitTestRequest(result.hitTestRequest()))

return false;

« no previous file with comments | « LayoutTests/fast/events/event-on-culled_inline-expected.txt ('k') | Source/core/layout/line/InlineFlowBox.cpp » ('j') | no next file with comments »