Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Side by Side Diff: Source/core/layout/LayoutInline.cpp

Issue 947793002: Reland "We need to account for culled inline parents of hit-tested nodes" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 794 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 private: 805 private:
806 bool m_intersected; 806 bool m_intersected;
807 Region& m_region; 807 Region& m_region;
808 const HitTestLocation& m_location; 808 const HitTestLocation& m_location;
809 }; 809 };
810 810
811 } // unnamed namespace 811 } // unnamed namespace
812 812
813 bool LayoutInline::hitTestCulledInline(HitTestResult& result, const HitTestLocat ion& locationInContainer, const LayoutPoint& accumulatedOffset) 813 bool LayoutInline::hitTestCulledInline(HitTestResult& result, const HitTestLocat ion& locationInContainer, const LayoutPoint& accumulatedOffset)
814 { 814 {
815 ASSERT(result.isRectBasedTest() && !alwaysCreateLineBoxes()); 815 ASSERT(!alwaysCreateLineBoxes());
816 if (!visibleToHitTestRequest(result.hitTestRequest())) 816 if (!visibleToHitTestRequest(result.hitTestRequest()))
817 return false; 817 return false;
818 818
819 HitTestLocation tmpLocation(locationInContainer, -toLayoutSize(accumulatedOf fset)); 819 HitTestLocation tmpLocation(locationInContainer, -toLayoutSize(accumulatedOf fset));
820 820
821 Region regionResult; 821 Region regionResult;
822 HitTestCulledInlinesGeneratorContext context(regionResult, tmpLocation); 822 HitTestCulledInlinesGeneratorContext context(regionResult, tmpLocation);
823 generateCulledLineBoxRects(context, this); 823 generateCulledLineBoxRects(context, this);
824 824
825 if (context.intersected()) { 825 if (context.intersected()) {
(...skipping 629 matching lines...) Expand 10 before | Expand all | Expand 10 after
1455 } 1455 }
1456 1456
1457 void LayoutInline::invalidateDisplayItemClients(const LayoutBoxModelObject& pain tInvalidationContainer) const 1457 void LayoutInline::invalidateDisplayItemClients(const LayoutBoxModelObject& pain tInvalidationContainer) const
1458 { 1458 {
1459 LayoutBoxModelObject::invalidateDisplayItemClients(paintInvalidationContaine r); 1459 LayoutBoxModelObject::invalidateDisplayItemClients(paintInvalidationContaine r);
1460 for (InlineFlowBox* box = firstLineBox(); box; box = box->nextLineBox()) 1460 for (InlineFlowBox* box = firstLineBox(); box; box = box->nextLineBox())
1461 paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*box); 1461 paintInvalidationContainer.invalidateDisplayItemClientOnBacking(*box);
1462 } 1462 }
1463 1463
1464 } // namespace blink 1464 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/fast/events/event-on-culled_inline-expected.txt ('k') | Source/core/layout/line/InlineFlowBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698