Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 947453003: IgnoreCertError should check if the error is a certificate error. (Closed)

Created:
5 years, 10 months ago by davidben
Modified:
5 years, 10 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IgnoreCertError should check if the error is a certificate error. This only affects one of the two callers. --ignore-certificate-error ends up causing some metrics to record on all errors rather than just certificate ones, so we end up recording things based on a default-initialized SSLInfo. BUG=none Committed: https://crrev.com/d3f1515455e2b8ce6d7d33dffea95bc7a86fa559 Cr-Commit-Position: refs/heads/master@{#317442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M net/socket/ssl_client_socket.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
Here are the two callers of this function. One already assumes IsCertificateError, so it's a ...
5 years, 10 months ago (2015-02-20 20:52:31 UTC) #2
Ryan Sleevi
lgtm
5 years, 10 months ago (2015-02-20 22:24:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947453003/1
5 years, 10 months ago (2015-02-20 22:25:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 23:43:17 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 23:43:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3f1515455e2b8ce6d7d33dffea95bc7a86fa559
Cr-Commit-Position: refs/heads/master@{#317442}

Powered by Google App Engine
This is Rietveld 408576698