net/socket/ssl_client_socket_pool.cc - Issue 947453003: IgnoreCertError should check if the error is a certificate error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_pool.cc

Issue 947453003: IgnoreCertError should check if the error is a certificate error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket_pool.cc

diff --git a/net/socket/ssl_client_socket_pool.cc b/net/socket/ssl_client_socket_pool.cc

index 64b6d67f032d8121567f2624379e2c2d19a958cc..870be34bf2d0de36f79b32e72200647dd63f2e7d 100644

--- a/net/socket/ssl_client_socket_pool.cc

+++ b/net/socket/ssl_client_socket_pool.cc

@@ -499,7 +499,8 @@ int SSLConnectJob::DoSSLConnectComplete(int result) {

100);

SSLInfo ssl_info;

- ssl_socket_->GetSSLInfo(&ssl_info);

+ bool has_ssl_info = ssl_socket_->GetSSLInfo(&ssl_info);

+ DCHECK(has_ssl_info);

UMA_HISTOGRAM_ENUMERATION("Net.SSLVersion", SSLConnectionStatusToVersion(

ssl_info.connection_status),

« no previous file with comments | « net/socket/ssl_client_socket.cc ('k') | no next file » | no next file with comments »