Asyncstar - exception thrown before yield or await would not get caught

Asyncstar - exception thrown before yield or await would not get caught

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43948

[sigurdm, 2015-02-20 09:20:51]

sigurdm@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-02-20 12:16:08]

LGTM.

https://codereview.chromium.org/947433002/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/947433002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3736:
_wrapJsFunctionForAsync(body,
nit: the "(null)" drowns.
maybe:
Function wrapped = _wrapJs...(
   body, async_error_codes.SUCCESS);
wrapped(null);

?

https://codereview.chromium.org/947433002/diff/1/tests/language/asyncstar_thr...
File tests/language/asyncstar_throw_in_catch_test.dart (left):

https://codereview.chromium.org/947433002/diff/1/tests/language/asyncstar_thr...
tests/language/asyncstar_throw_in_catch_test.dart:41: await new
Future.error("Error2");
Unless this is tested in another test, you could add a foo4 that keeps this
line.

[sigurdm, 2015-02-23 11:24:11]

New patchsets have been uploaded after l-g-t-m from floitsch@google.com

[sigurdm, 2015-02-23 11:25:48]

Committed patchset #2 (id:20001) manually as 43948 (presubmit successful).

[sigurdm, 2015-02-23 12:33:50]

https://codereview.chromium.org/947433002/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/947433002/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3736:
_wrapJsFunctionForAsync(body,
On 2015/02/20 12:16:08, floitsch wrote:
> nit: the "(null)" drowns.
> maybe:
> Function wrapped = _wrapJs...(
>    body, async_error_codes.SUCCESS);
> wrapped(null);
> 
> ?

Done.

https://codereview.chromium.org/947433002/diff/1/tests/language/asyncstar_thr...
File tests/language/asyncstar_throw_in_catch_test.dart (left):

https://codereview.chromium.org/947433002/diff/1/tests/language/asyncstar_thr...
tests/language/asyncstar_throw_in_catch_test.dart:41: await new
Future.error("Error2");
On 2015/02/20 12:16:08, floitsch wrote:
> Unless this is tested in another test, you could add a foo4 that keeps this
> line.

Ok.
I removed the line, because it is never executed - but can make a version with
it in that does not get canceled.

[floitsch, 2015-02-23 13:15:13]

https://codereview.chromium.org/947433002/diff/1/tests/language/asyncstar_thr...
File tests/language/asyncstar_throw_in_catch_test.dart (left):

https://codereview.chromium.org/947433002/diff/1/tests/language/asyncstar_thr...
tests/language/asyncstar_throw_in_catch_test.dart:41: await new
Future.error("Error2");
On 2015/02/23 12:33:49, sigurdm wrote:
> On 2015/02/20 12:16:08, floitsch wrote:
> > Unless this is tested in another test, you could add a foo4 that keeps this
> > line.
> 
> Ok.
> I removed the line, because it is never executed - but can make a version with
> it in that does not get canceled.

Even if it is canceled it might still impact code generation.